Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested actions image alt text fallback #4441

Merged

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Oct 4, 2022

Related to #4333.

Changelog Entry

Fixed

  • Card action image alt text should use imageAltText field and fallback to text field, by @compulim in PR #4333

Description

Image on suggested actions should have alt text from imageAltText field, and fallback to text field.

Today, we support imageAltText field only. And did not fallback to text field.

This pull request will enable image alt text fallback using text field.

Specific Changes

  • Updated <SuggestedActions> to fallback to text field
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim added this to the release-4.15.5 milestone Oct 4, 2022
@compulim compulim marked this pull request as ready for review October 6, 2022 16:43
@compulim compulim force-pushed the fix-4333-suggested-actions-image-alt-text branch from c3e18d5 to 484a58c Compare October 6, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants