Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json is inconsistent with package-lock.json #4411

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 9, 2022

Fixes #4412.

Changelog Entry

Fixed

  • Fixes #4412. Fixed inconsistent in packages/support/cldr-data/package.json, by @compulim, in PR #4411

Description

In #4392, we missed committing packages/support/cldr-data/package.json. However, CI PR validation passed for unknown reason. Both our daily build and some dev boxes failed.

We are also enabling --force-local switch in Lerna to make sure this won't get pass CI PR validation next time.

Design

When running lerna bootstrap --ci, it may regard the --ci flag for a few reasons (non-exhaustive):

Since we adopted cldr-data, we are hitting point 3, thus, lerna disabled --ci.

We are adding a new --force-local switch to make sure we use the local version of cldr-data instead of NPM.

Specific Changes

  • Update packages/support/cldr-data/package.json to use glob@^8.0.3
    • We are using caret version as this package is used for pre-compile, and not production
  • Update lerna.json and add --force-local flag
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim merged commit 077641a into microsoft:main Sep 12, 2022
@compulim compulim deleted the fix-lockfile branch September 12, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packages/support/cldr-data/package.json is inconsistent with its lockfile
2 participants