Move emoticon replacement logic to withEmoji and fix undo stack
#4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
force-pushed
the
feat-with-emoji
branch
from
c03d8e2 to
d0bb4e6
Compare
compulim
changed the title
withEmojiwithEmoji
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
compulim
changed the title
withEmojiwithEmoji and fix undo stack
tdurnford
previously approved these changes
Sep 20, 2023
tdurnford
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Breaking changes
useTextBoxValuesetter will no longer replace emoticon with emoji, in PR #4861Fixed
Description
This is related to input modality.
Fixes CTRL + Z to rewriting the undo stack. Also refactored as
withEmoji.Design
Refactoring to
withEmoji. In future, web devs can build their own send box with our emoticon replacement logic.However, to support
withEmoji, theuseTextBoxValuewill no longer provide emoticon replacement logic.Specific Changes
withEmojiHOC componentSendBox/TextBoxto usewithEmojiuseTextBoxValuenot to provide emoticon replacement logicemoji.jsto HTML testCHANGELOG.mdReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)