Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.16.0 and native chevron of accordion in citation should be hidden #4958

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Nov 17, 2023

Fixes #4957.

Changelog Entry

Breaking changes

  • Starting from 4.16.0, Internet Explorer is no longer supported
    • After more than a year of the Internet Explorer 11 officially retirement, we decided to stop supporting Internet Explorer. This will help us to bring new features to Web Chat
    • 4.15.9 is the last version which supports Internet Explorer in limited fashion

Fixed

  • Fixes #4957. Native chevron of the accordion in citation should be hidden, by @compulim, in PR #4958

Description

Native chevron of accordion in citation should be hidden.

Specific Changes

  • Bumps to 4.16.0 and bids farewell to Internet Explorer
  • Hid native chevron of accordion in citation via ::-webkit-details-marker
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim marked this pull request as ready for review November 17, 2023 02:01
tdurnford
tdurnford previously approved these changes Nov 17, 2023
@compulim compulim merged commit ab8ab69 into main Nov 17, 2023
10 checks passed
@compulim compulim deleted the bump-4.16.0 branch November 17, 2023 19:45
@compulim compulim mentioned this pull request Nov 17, 2023
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari: native chevron in citation accordion should be hidden
2 participants