-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Adaptive Cards to 3.0.2 #5115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
March 30, 2024 17:35
tdurnford
approved these changes
Apr 1, 2024
11 tasks
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
adaptivecards@3.0.2
Description
Bump Adaptive Cards JS SDK to 3.0.2 to support Adaptive Cards.
However, AC JS SDK requires
swiper
but they forget to include it as their production dependencies. We are addingswiper@^8.2.6
to workaround their issue.Design
Some features in Adaptive Cards are in preview or designed to use outside of Bot Framework. Web Chat does not support these features.
One notable example is "dynamic typeahead" feature in Adaptive Cards. This feature is not localized and strings are hardcoded in their source code. Web Chat does not support "dynamic typeahead".
Web Chat does not support universal action model (a.k.a.
Action.Execute
). This is because our chat adapter does not support invoke activity. Changes would need to be made in the chat adapter before Web Chat can supportAction.Execute
.Specific Changes
adaptivecards@3.0.2
CHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)