-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent theme] Fix files and default exports #5131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
Fix files and default exports
[Fluent theme] Fix files and default exports
Apr 12, 2024
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 12, 2024 18:53
tdurnford
previously approved these changes
Apr 12, 2024
tdurnford
approved these changes
Apr 15, 2024
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120botframework-webchat-fluent-theme/package.json
to export*.d.[m]ts
and default exports, in PR #5131Description
Files that need to be exported in the
package.json
should be included in thepackage.json/files
.Also, default exports should point to valid file.
Design
Specific Changes
packages/fluent-theme/package.json
*.d.[m]ts
tofiles
so it is packed correctlymain
/types
field so it is pointing to correct filesCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)