-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent theme] Hide buttons, suggested actions FnF and flow layout, DTMF FnF #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 13, 2024 00:55
OEvgeny
reviewed
Apr 13, 2024
packages/fluent-theme/src/components/suggestedActions/SuggestedAction.tsx
Show resolved
Hide resolved
OEvgeny
approved these changes
Apr 13, 2024
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgeny, in PR #5120styleOptions.hideUploadButton
, in PR #5132styleOptions.hideTelephoneKeypadButton
and default totrue
, in PR #5132Description
Some fit-and-finish work for suggested actions and telephone keypad in Fluent skin pack. Please look at Specific Changes section for details.
Design
styleOptions.hideTelephoneKeypad
Added a new
hideTelephoneKeypad
style options. However, this is marked as experimental. Soon, we will be working on input modality and this style options will probably be superseded by the input modality feature.Also, the telephone keypad UX should be made available to our current white-label experience.
Specific Changes
styleOptions.suggestedActionLayout
of"flow"
"carousel"
layout is currently not supportedCHANGELOG.md
Review Checklist
Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)