-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: integrate webchat focus management #5150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 29, 2024 22:27
I'll update usage with |
OEvgeny
force-pushed
the
feature/focus-pocus
branch
from
April 30, 2024 18:34
50881d6
to
046997d
Compare
compulim
reviewed
Apr 30, 2024
compulim
reviewed
Apr 30, 2024
compulim
approved these changes
May 1, 2024
11 tasks
This was referenced Aug 1, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgenyuseFocusSendBox()
hook, please useuseFocus('sendBox')
instead, by @OEvgeny, in PR #5150Description
The PR refactors existing sendbox focus management code to use
use-propagate
provided hooks and exposes the newly addeduseRegisterFocusSendBox
hook along withSendBoxFocusOptions
so that Fluent SendBoxe's focus can be wired-in and managed by WebChat.Design
The new
component/src/hooks/sendBoxFocus
file containsuseRegisterFocusSendBox
,useFocusSendBox
hooks which are used in place of the old context.Context bindings and other related code was removed.
Specific Changes
use-propagate
dependencyusePropogate
for sendbox focususeFocusSendBox
hoook-
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed