-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: suggested actions roving focus #5154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
commented
May 1, 2024
packages/fluent-theme/src/components/suggestedActions/private/rovingFocus.tsx
Outdated
Show resolved
Hide resolved
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 1, 2024 20:23
compulim
reviewed
May 1, 2024
packages/fluent-theme/src/components/suggestedActions/SuggestedAction.tsx
Show resolved
Hide resolved
compulim
reviewed
May 1, 2024
packages/fluent-theme/src/components/suggestedActions/SuggestedAction.tsx
Outdated
Show resolved
Hide resolved
compulim
approved these changes
May 1, 2024
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim and @OEvgenyDescription
Implemented roving focus using existing implementation as a reference. The new component is now used for suggested actions keyboard support.
Design
The new
rovingFocus
module implements the roving focus exposing only theRovingFocusProvider
anduseRovingFocusItemRef
.The module is private for
suggestedActions
for now. When we find other use-case, we can reconsider and refactor it.Specific Changes
-
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed