-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Improved performance for useActivityTreeWithRenderer
#5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 3, 2024 19:07
compulim
commented
May 3, 2024
tdurnford
previously approved these changes
May 3, 2024
OEvgeny
reviewed
May 8, 2024
OEvgeny
approved these changes
May 8, 2024
This was referenced Oct 2, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
useActivityTreeWithRenderer
, in PR #5163, by @compulimDescription
useActivityTreeWithRenderer
slowdown exponentially. We are working on the bin logics.New tests added are not in our test suite yet as we are still exploring how to write performance tests.
Note: the total time needed to render the chat history is not changed significantly.
Design
Today, we are using
[].find(entry => entry.activity === activity)
to find an entry.We are building a temporary
Map
so we can use indexing to achieve higher performance,Map.get(activity)
.Before
At 3th activity:
At 197th activity:
After
At 3th activity:
At 197th activity:
Specific Changes
useActivityTreeWithRenderer
to useMap
skipWait
option in Direct Line EmulatorCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)