-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf: allow useMemoAll to cache results independently from deps #5172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
May 7, 2024 01:53
compulim
reviewed
May 7, 2024
Literally we need to select one of 2 routes:
I think we should follow What I observed from React API:
|
OEvgeny
force-pushed
the
perf/activity-render
branch
from
May 7, 2024 16:20
026025e
to
91fa558
Compare
OEvgeny
force-pushed
the
perf/activity-render
branch
from
May 7, 2024 16:21
91fa558
to
8594f10
Compare
Instead of |
compulim
previously approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicking.
packages/component/src/providers/ActivityTree/private/useActivitiesWithRenderer.ts
Outdated
Show resolved
Hide resolved
…itiesWithRenderer.ts Co-authored-by: William Wong <compulim@users.noreply.github.com>
compulim
approved these changes
May 8, 2024
This was referenced Oct 2, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
useActivityWithRenderer
, in PR #5172, by @OEvgenyDescription
Thanks to the optimization, now subsequent activity re-renders are cached. The downside is that the
useMemoAll
hook cached results are not discarded whenuseMemo
dependencies are updated.Design
The initial implementation provided in the PR was caching per functions globally (see the first commit). Now we cache per hook call to align better with
useMemo
.Note that if we aim to maintain full parity with
useMemo
, we shouldn't make this optimization. But it'd make the implementation similar to defining and using the memoized function directly inuseMemo
hook making this hook obsolete.The updated implementation is rather not as trivial and solves use-cases for caching results even after dependencies change,
Specific Changes
useMemoAll
hook implementationuseMemoize
->useMemoAll
as suggested-
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)