Fluent: increase send box text size to prevent unwanted zoom on mobile #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
changed the title
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
|
Is there any other ways than changing font size...? |
Our users can opt-out from pinch to zoom to prevent the zoom-in action. But overall 16px min font-size on controls is a platform requirement. |
|
Need changelog and this is good. 🙂 |
compulim
approved these changes
May 28, 2024
OEvgeny
added a commit
that referenced
this pull request
May 30, 2024
#5192) * Fluent: increase focused send box text size to prevent unwanted zoom on mobile * Self review * Changelog
OEvgeny
added a commit
that referenced
this pull request
Jun 26, 2024
#5192) * Fluent: increase focused send box text size to prevent unwanted zoom on mobile * Self review * Changelog
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 2, 2024
Open
Open
Open
This was referenced Oct 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 31, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
Increase the default font size only when focused and only when both: hover is not supported and coarse pointer conditions apply.
Design
We may want to remove
hover: nonepart to target any device with coarse pointer, but usually hover support means that there might be other ways to hover which include more precise navigation.Specific Changes
CHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)