Update Gemini dev server and serve 4.17 #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
OEvgeny
previously approved these changes
May 29, 2024
OEvgeny
reviewed
May 29, 2024
OEvgeny
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Changed
http-proxy-middleware@3.0.0Description
(Gemini is the HTML page behind https://webchat.botframework.com/embed//gemini, which host Web Chat on Azure Bot Services.)
Fixed Gemini dev server to host the bits with latest dependencies.
Navigate to http://localhost:5002 to connect to MockBot.
Or
http://localhost:5002/embed/<my-bot-id>/gemini?b=<my-bot-id>&t=<token>to connect to any bots.Design
We are still keeping Webpack 5 instead of esbuild. Pug is not well-supported in esbuild and writing the plug-in ourselves seems overkill for now.
Specific Changes
servicingPlan.jsonto serve 4.17 for both current andnextminorFCBhttp-proxy-middlewarerestifytoexpressnode-fetchdist/index.htmltodist/gemini.htmlfor easier deploying to Azure Bot ServicesI have added tests and executed them locallyCHANGELOG.mdI have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.jsonandpackage-lock.jsonreviewedSecurity reviewed (no data URIs, check for nonce leak)Tests reviewed (coverage, legitimacy)