-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add decorators #5205
Merged
Merged
feat: Add decorators #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
reviewed
Jun 11, 2024
compulim
reviewed
Jun 12, 2024
compulim
reviewed
Jun 12, 2024
compulim
reviewed
Jun 12, 2024
compulim
reviewed
Jun 12, 2024
compulim
reviewed
Jun 12, 2024
compulim
reviewed
Jun 12, 2024
Co-authored-by: William Wong <compulim@users.noreply.github.com>
OEvgeny
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
June 14, 2024 18:03
compulim
reviewed
Jun 14, 2024
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
botframework-webchat-api/decorator
import, in PR #5205, by @OEvgenyDecoratorComposer
andActivityDecorator
to be used for decorating activity border, in PR #5205, by @OEvgenyDescription
This adds a way to decorate various things in WebChat in the future. For now it supports activity decoration with a custom border.
Design
The design introduces decorators to WebChat. The current implementation includes support for activity decoration with custom border decorator.
Key components of the design:
ActivityBorderDecoratorMiddleware
: Middleware stack for managing activity border changesActivityDecorator
: A React component for decorating activities e.g. inside of the WebChat or activity middlewaresDecoratorComposer
: Allows multiple decorators to be passed together and initialized according to the type of decoratorcreateDecoratorComposer
: A factory function for creating decorator composerActivityDecoratorRequestType
: Describes activity decorator requestFlow
DecoratorComposer
DecoratorComposer
initializes these functions based on the decorators typeactivity
to theActivityDecorator
to form a request and process middlewars, which apply the appropriate changesSpecific Changes
-
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)z-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)