proritize given citation names as titles #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle2
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath and
tdurnford
as code owners
tdurnford
reviewed
Jun 24, 2024
packages/component/src/Attachment/Text/private/MarkdownTextContent.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Jun 24, 2024
packages/component/src/Attachment/Text/private/MarkdownTextContent.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Jun 24, 2024
packages/component/src/Attachment/Text/private/MarkdownTextContent.tsx
Outdated
Show resolved
Hide resolved
tdurnford
reviewed
Jun 25, 2024
tdurnford
approved these changes
Jun 25, 2024
This was referenced Aug 1, 2024
Open
Open
Open
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Description
This lets us use the "name" field on citations as a higher-priority source for a citation name rather than falling back to what we read out of the citation text.
Specific Changes
Adds
messageCitation.appearance.nameas the preferred default source for a name overmarkdownDefinition.title.CHANGELOG.mdReview Checklist