Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proritize given citation names as titles #5215

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Conversation

beyackle2
Copy link
Contributor

@beyackle2 beyackle2 commented Jun 18, 2024

Fixes #5209

Changelog Entry

  • Read deeper into citation objects in order to provide names, in PR , by @beyackle2

Description

This lets us use the "name" field on citations as a higher-priority source for a citation name rather than falling back to what we read out of the citation text.

Specific Changes

Adds messageCitation.appearance.name as the preferred default source for a name over markdownDefinition.title.

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md

Review Checklist

This section is for contributors to review your work.

  • Browser and platform compatibilities reviewed
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • Tests reviewed (coverage, legitimacy)

@beyackle2 beyackle2 marked this pull request as draft June 19, 2024 23:18
@beyackle2 beyackle2 marked this pull request as ready for review June 20, 2024 19:46
@beyackle2 beyackle2 enabled auto-merge (squash) June 20, 2024 20:21
Copy link
Collaborator

@OEvgeny OEvgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Citation list should use names from entities instead of Markdown
4 participants