-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Copy button to white label UX #5262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
Add Copy button to white label
Add Copy button to white label UX
Aug 17, 2024
compulim
force-pushed
the
feat-white-label-copy-button
branch
from
August 17, 2024 03:24
6aa03b9
to
89a990b
Compare
OEvgeny
reviewed
Aug 17, 2024
Solid work. It looks like it should be done this way 🚀 |
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
August 18, 2024 20:20
OEvgeny
previously approved these changes
Aug 19, 2024
OEvgeny
reviewed
Aug 19, 2024
OEvgeny
reviewed
Aug 19, 2024
OEvgeny
reviewed
Aug 19, 2024
OEvgeny
reviewed
Aug 19, 2024
OEvgeny
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
AllowCopy
, in PR #5259 and #5262, by @compulimDescription
Ported the "Copy" button to both white-label and Fluent/Copilot theme.
Design
The "Copy" button would show up if:
message
, and;text
field, and;Message
thing inentities
field with@id
of empty string, and;Message
thing haskeywords
containing"AllowCopy"
If the
textFormat
is unset or"markdown"
, both plain text and HTML text version of the message will be copied to the clipboard.For example,
Specific Changes
CHANGELOG.md
I have updated documentationReview Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)