-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluent: add decorators for loading and completion states #5269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
a-b-r-o-w-n,
compulim,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
August 28, 2024 19:45
compulim
reviewed
Aug 28, 2024
packages/fluent-theme/src/components/decorator/private/BorderLoader.module.css
Outdated
Show resolved
Hide resolved
compulim
reviewed
Aug 28, 2024
packages/fluent-theme/src/components/decorator/private/BorderLoader.module.css
Outdated
Show resolved
Hide resolved
compulim
reviewed
Aug 28, 2024
compulim
reviewed
Aug 28, 2024
packages/fluent-theme/src/components/decorator/private/BorderLoader.module.css
Outdated
Show resolved
Hide resolved
compulim
reviewed
Aug 28, 2024
compulim
previously approved these changes
Aug 28, 2024
Co-authored-by: William Wong <compulim@users.noreply.github.com>
compulim
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Description
This PR enhances the Fluent theme by introducing decorators for loading and completion states of activities.
Design
Added two new components:
BorderLoader
: Displays an animated loading bar for activities in the preparation state.BorderFlair
: Shows a colorful animated border for activities in the completion state.Then
WebChatDecorator
applies them based on the activity's livestreaming state. The implementation uses CSS animations and custom properties for flexibility and performance.Specific Changes
BorderFlair.module.css
andBorderFlair.tsx
BorderLoader.module.css
andBorderLoader.tsx
Decorator.tsx
to use newBorderFlair
andBorderLoader
componentsFlair.tsx
,Loader.tsx
, etc.)FluentThemeProvider.tsx
to wrap children withWebChatDecorator
Theme.module.css
withBuiltinDecorator.html
for visual testing-
CHANGELOG.md
I have updated documentationReview Checklist
z-index
)package.json
andpackage-lock.json
reviewed