Seal concluded livestream and allow final activity without streamSequence #5273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
streamSequence
is not required in final activity, in PR #5273, by @compulimDescription
Concluded livestream should not be open to any further incoming activities.
Also, final activity in the livestream do not requires
channelData.streamSequence
to be set. It will be assumedInfinity
so it is always the last one.Design
channelData.streamSequence
is useful for out-of-order interim activities. But for final activities, as it always conclude the livestream and seal from further activities,streamSequence
is not used in the scenario. Thus, we are taking away this requirement.Specific Changes
activities
reducer to ignore activities for concluded livestreamgetActivityLivestreamMetadata
to relaxstreamSequence
for final activityCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)