Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix samples (second round) #5300

Merged
merged 28 commits into from
Sep 20, 2024
Merged

Fix samples (second round) #5300

merged 28 commits into from
Sep 20, 2024

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Sep 20, 2024

Fixes #5267.

Changelog Entry

(No changelog for samples)

Description

Fixed building some samples. Removed 01.g.hybrid-react-npm sample. Disabled workflow for deploying SSO samples (no live demo).

Specific Changes

  • Added /samples/package.json as NPM workspaces
  • Removed 01.g.hybrid-react-npm sample
  • Removed live demo for SSO samples
  • Added punycode to some samples
  • Updated GitHub workflow to use latest version of actions
    • actions/checkout@v2 is deprecated and will throw error on run
    • actions/upload-artifact@v4 produce immutable artifacts (won't merge across matrix steps)
      • actions/upload-artifact/merge@v4 will merge artifacts
    • actions/download-artifact@v4 need to pair up with actions/upload-artifact@v4
    • Using xargs to simplify workflow
    • Removed secure feed
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@compulim compulim changed the title [WIP] Fix samples (second round) Fix samples (second round) Sep 20, 2024
@compulim compulim changed the title Fix samples (second round) [WIP] Fix samples (second round) Sep 20, 2024
@compulim compulim changed the title [WIP] Fix samples (second round) Fix samples (second round) Sep 20, 2024
@compulim compulim marked this pull request as ready for review September 20, 2024 19:03
@compulim compulim merged commit 0ef9680 into microsoft:main Sep 20, 2024
24 checks passed
@compulim compulim deleted the fix-samples-2 branch September 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Chat Hosted Samples Maintainance
2 participants