Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove unused single letter class in carousel #5325

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Oct 10, 2024

Fixes #5323

Changelog Entry

  • Fixes #5323. Removed unused CSS class from carousel component, eliminating unintended styling, in PR #5325, by @OEvgeny

Description

This PR removes an unused single-letter CSS class c from the CarouselFilmStrip component.

Design

When evanw/esbuild#3484 is resolved by esbuild, we'll update our build configuration to make it harder to target our minified classes.

Specific Changes

  • Removed the class c from the div with class webchat__carousel-filmstrip__complimentary-content in CarouselFilmStrip.js
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review October 10, 2024 18:18
@compulim compulim merged commit 718d58d into main Oct 10, 2024
27 checks passed
@compulim compulim deleted the fix/single-letter-class branch October 10, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel height set to 20px cannot see content
2 participants