-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added continuous listening functionality which is controlled by prop #5397
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach needs validation and input from @compulim
The PR description is missing PR number and contributor links from Changelog section.
The PR is missing the CHANGELOG.md
file update.
Updated the description. |
The approach needs validation and input from @compulim
It need to set AFAIR, either Android or Safari doesn't works with Also, need to handle multiple results with In each continuous session, all result will be represented on every single Make sure manual testing is done on browser-provided speech and Azure AI Speech, also done on all browser combination: Edge, Chrome, Firefox, Android Chrome, macOS Safari, iOS Safari, iPadOS Safari. I.e. 14 manual tests. I guess this doesn't need a new hook or saga, because it is native in W3C Web Speech API. For Android/Safari quirks, should ponyfill a fix for their bug in a separate layer. I.e. don't fix browser issue directly inside Web Chat data/Redux layer. But fix it in the speech factory layer. |
Changelog Entry
Added
Description
Design
enableContinuousListening
prop to manage the continuous listening mode. This prop essentially manages the dictate state to keep the listening mode active after sending a message.Specific Changes
Composer
component will accept a new prop calledenableContinuousListening
.continuousListening
state has been created in the Redux store, and theComposer
component will initialize its value.Continuous_Listening.mp4
CHANGELOG.md
Review Checklist
z-index
)package.json
andpackage-lock.json
reviewed