-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masking password input with backchannel event #976
Conversation
Generally we encourage bot developers not to use bots for passwords, PII, and other secure data. Although Web Chat and Direct Line are secure, sending things like passwords through the same channel as the rest of the text tends to lead to bad situations. You wouldn't want passwords in LUIS utterances, for example, which are often made available widely to people in an organization. But in this PR is a hint of a way forward. Just as you send a special type of activity from the server to initiate a password, you could also send one to the server with the password. This would allow you to create a secure pathway separate from the normal text pathway. This would have to follow all the best practices for passwords. Do other channels have special affordances for passwords? I would think of the server->client activity as an extension of (I'd want an actual security expert to look at this and chime in.) Some notes about your implementation:
@compulim @vishwacsena I think this idea is worth considering. |
(Also, it’s better to raise an issue than go straight to a PR.) |
I understand the need to send secret over. A few things on UX:
We could use |
re: adaptive cards, maybe. Those still send In terms of UX, we can all have opinions, but ultimately the the only way to know what users will prefer is user testing. I'd put an Adaptive Cards password form up against a version of this with clearer chrome, e.g. the input field says "enter your password here" with a standard "show password" checkbox. I don't think we need further encryption - Direct Line is tl;dr let's decide whether some version of this feature makes sense and is worth investing in. If so, let's bring in some experts to decide how to proceed. |
The feature did not go into Direct Line as a standard event. Until we get this event into Direct Line, I prefer it to be done as a sample so people can "opt-in". You can look at one of the samples that customize activity. And implementing a new activity that render a password box. Since the new sample would be very different from this PR, I am closing this one. Please feel free to submit another PR for this work. |
This is the tracking issue for the sample, #1413. |
If you send the following event to WebChat through the backchannel, the input box will become a password input until you send a message.
Event:
Demo: