Skip to content

fix: Increase retry attempts and improve error messaging for file upload script #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix: Increase retry attempts and improve error messaging for file upload script #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions infra/scripts/copy_kb_files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,46 +123,54 @@ echo "Uploading files to Azure Blob Storage"
# Using az storage blob upload-batch to upload files with managed identity authentication, as the az storage fs directory upload command is not working with managed identity authentication.
az storage blob upload-batch --account-name "$storageAccount" --destination data/"$extractedFolder1" --source $extractionPath1 --auth-mode login --pattern '*' --overwrite --output none
if [ $? -ne 0 ]; then
retries=3
maxRetries=5
retries=$maxRetries
Copy link

Copilot AI Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry logic is duplicated between two upload operations. Consider extracting this into a reusable function to reduce code duplication and improve maintainability.

Copilot uses AI. Check for mistakes.
sleepTime=10
echo "Error: Failed to upload files to Azure Blob Storage. Retrying upload...($((4 - retries)) of 3)"
attempt=1
while [ $retries -gt 0 ]; do
echo "Error: Failed to upload files to Azure Blob Storage. Retrying upload...$attempt of $maxRetries in $sleepTime seconds"
sleep $sleepTime
az storage blob upload-batch --account-name "$storageAccount" --destination data/"$extractedFolder1" --source $extractionPath1 --auth-mode login --pattern '*' --overwrite --output none
if [ $? -eq 0 ]; then
echo "Files uploaded successfully to Azure Blob Storage."
break
else
((retries--))
echo "Retrying upload... ($((4 - retries)) of 3)"
((attempt++))
sleepTime=$((sleepTime * 2))
sleep $sleepTime
fi
done
exit 1
if [ $retries -eq 0 ]; then
echo "Error: Failed to upload files after all retry attempts."
exit 1
fi
else
echo "Files uploaded successfully to Azure Blob Storage."
fi

az storage blob upload-batch --account-name "$storageAccount" --destination data/"$extractedFolder2" --source $extractionPath2 --auth-mode login --pattern '*' --overwrite --output none
if [ $? -ne 0 ]; then
retries=3
maxRetries=5
retries=$maxRetries
attempt=1
sleepTime=10
echo "Error: Failed to upload files to Azure Blob Storage. Retrying upload...($((4 - retries)) of 3)"
while [ $retries -gt 0 ]; do
echo "Error: Failed to upload files to Azure Blob Storage. Retrying upload...$attempt of $maxRetries in $sleepTime seconds"
sleep $sleepTime
az storage blob upload-batch --account-name "$storageAccount" --destination data/"$extractedFolder2" --source $extractionPath2 --auth-mode login --pattern '*' --overwrite --output none
if [ $? -eq 0 ]; then
echo "Files uploaded successfully to Azure Blob Storage."
break
else
((retries--))
echo "Retrying upload... ($((4 - retries)) of 3)"
((attempt++))
sleepTime=$((sleepTime * 2))
sleep $sleepTime
fi
done
exit 1
if [ $retries -eq 0 ]; then
echo "Error: Failed to upload files after all retry attempts."
exit 1
fi
else
echo "Files uploaded successfully to Azure Blob Storage."
fi
Expand Down