fix: added new 'type' tag for WAF and Non-WAF deployement #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VishalS-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Sep 23, 2025
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Sep 29, 2025
* fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Roopan-Microsoft
pushed a commit
that referenced
this pull request
Oct 1, 2025
…emoved the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com> Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com>
Roopan-Microsoft
added a commit
that referenced
this pull request
Oct 3, 2025
…on & updated docs (#692) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Create new Managed Identity for SQL operations with least privileges * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps * removed SQL user assigned identity from key vault and SQL DB module * Refactor DNS zone naming and update SQL database redundancy settings * fix pylint issues * refactor: Update README, azure.yml for minimum azd version 1.18.0 & removed the unsued params (#690) * fix: Dev to main (#681) * fix: added tags in CAdeploy.yml file (#675) * CI Pipeline fix for Client Advisor * added tags in CAdeploy.yml file * add my feature branch * tags changes updated in CAdeploy.yml file * added template name condition based * removed my feature branch from pipeline * Additional Troubleshooting steps * fix: Remove createdby from pipeline and add change Createdby logic in bice… (#678) * Remove createdby from pipeline and add change Createdby logic in bicep file * Add 'createdBy' parameter to Azure deployment * Add 'createdBy' parameter for tagging * added new 'type' tag (#682) * Update docs/TroubleShootingSteps.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update GitHub Issues link in troubleshooting steps --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Removed commented params * Update README and azure.yml for minimum azd version 1.18.0 --------- Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com> Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Prajwal D C <v-dcprajwal@microsoft.com> * Update Azure template validation action to latest version * Update azure-dev.yml * Update azure-dev.yml * Chore: Disable Dev Container usage in Azure validation step Disable the use of Dev Container for Azure template validation. * chore: Refactor Azure DevOps workflow configuration * fix: Rename main.bicep for network module * chore: Update Azure template validation action version * chore: Add validateTests parameter to Azure Dev workflow * chore: Update Azure template validation action version * fix post deployment script to support exp * refactor: Comments fixed --------- Co-authored-by: VishalS-Microsoft <v-vishshinde@microsoft.com> Co-authored-by: NirajC-Microsoft <v-nirajcha@microsoft.com> Co-authored-by: Harsh-Microsoft <v-hbangera@microsoft.com> Co-authored-by: Vamshi-Microsoft <v-vamolla@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Roopan-Microsoft <168007406+Roopan-Microsoft@users.noreply.github.com>
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the tagging logic in the
resourceGroupTagsresource withininfra/main.bicepto improve clarity and consistency around template naming and resource type identification.Tagging improvements:
TemplateNametag is now always set to'Client Advisor', removing conditional logic based onenablePrivateNetworking.Typetag has been introduced, which is set to'WAF'ifenablePrivateNetworkingis true, or'Non-WAF'otherwise, making the resource type explicit in the tags.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information