Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate gRPC C++ types under a grpc namespace #4312

Closed
eddyashton opened this issue Oct 5, 2022 · 1 comment · Fixed by #4323
Closed

Generate gRPC C++ types under a grpc namespace #4312

eddyashton opened this issue Oct 5, 2022 · 1 comment · Fixed by #4323
Assignees
@eddyashton
Labels
gRPC gRPC support to support external executors
Milestone
4.x

Comments

@eddyashton
Copy link
Member

Currently we have files like status.proto generating a type called ccf::Status. This type should be in a different namespace so they don't collide with existing types, and don't squat top-level CCF names. I think this should be ccf::grpc::Status, but that's open for discussion.
@eddyashton eddyashton added the TODO label Oct 5, 2022
@jumaffre
Copy link
Contributor

jumaffre commented Oct 6, 2022

Linking this to #4211

@shokouedamsr shokouedamsr added this to the 3.x milestone Oct 7, 2022
@achamayou achamayou added the S label Oct 7, 2022
@eddyashton eddyashton self-assigned this Oct 7, 2022
@shokouedamsr shokouedamsr modified the milestones: 3.x, 4.x Oct 7, 2022
@shokouedamsr shokouedamsr added 4.x and removed 3.x labels Oct 7, 2022
@eddyashton eddyashton mentioned this issue Oct 7, 2022
Merged
@jumaffre jumaffre added the gRPC gRPC support to support external executors label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyashton eddyashton

Labels
gRPC gRPC support to support external executors
Projects
None yet
Milestone
4.x
Development

Successfully merging a pull request may close this issue.

Move namespace of proto generated C++ types eddyashton/CCF
4 participants
@achamayou @eddyashton @jumaffre @shokouedamsr