Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move namespace of proto generated C++ types #4323

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

eddyashton
Copy link
Member

Resolves #4312.

I opted for a protobuf namespace rather than a grpc namespace, since we're purely talking about the generated protobuf types (we don't use the generated gRPC stubs). Also distinguished ccf::protobuf (things that might be shared as part of general CCF gRPC support) and externalexecutor::protobuf (things extremely specific to the external_executor execution engine).

The annoying side effect of this is that we also change the URLs where these RPCs are served, but I think that's fine because they're hidden in generated gRPC code. I thought we could override those with the google.api.http option, but it turns out that's purely about the JSON mapping, not the gRPC-over-HTTP2 mapping.

@eddyashton eddyashton requested a review from a team October 7, 2022 10:38
@ghost
Copy link

ghost commented Oct 7, 2022

grpc_ccf@51029 aka 20221007.18 vs main ewma over 20 builds from 50620 to 51025

Click to see table

main

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem tpcc_sgx_cft^ tpcc_sgx_cft_mem hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
50620 20221004.1 11239.8 0 40644.5 0 10587 0 4716.91 0 3685.74 0 3395.47 0 6314.73 8.37592e+07 28727.9 19814.6 1.6126e+07 5571.45 1.50774e+07 2498.25 9.83456e+06 2121.1 9.57242e+06 1932.03 9.04813e+06 900889 1.37182e+06 9.34302e+06 3.56174e+07
50640 20221004.9 11241.3 0 40956.9 0 10399.6 0 4735.03 0 3672.16 0 3385.96 0 6211.03 8.29727e+07 24392.8 19513.4 1.69124e+07 5575.63 1.53396e+07 2540.36 1.00967e+07 2073.5 9.57242e+06 1934.35 9.31027e+06 906911 1.36624e+06 9.20032e+06 3.53707e+07
50662 20221004.17 11391.1 0 43259.3 0 10730.8 0 4598.71 0 3635.31 0 3359.09 0 6299.81 8.32349e+07 25723.8 19685 1.69124e+07 5278.93 1.58639e+07 2540.89 1.00967e+07 2076.8 1.21939e+07 1925.34 9.04813e+06 911509 1.38433e+06 9.25432e+06 3.58663e+07
50695 20221004.32 11710.6 0 43432.4 0 10815 0 4704.88 0 3682.08 0 3243.82 0 6303.06 8.40213e+07 29747.8 19520.1 1.71746e+07 5561.24 1.58639e+07 2490.15 9.83456e+06 2112.8 9.31027e+06 1891.12 9.04813e+06 906390 1.37228e+06 9.28794e+06 3.55556e+07
50717 20221004.42 11317.4 0 40827.8 0 10447.2 0 4621.53 0 3731.5 0 3359.02 0 6350.09 8.32349e+07 32154.5 19695.5 1.66503e+07 5643.42 1.53396e+07 2516.63 9.83456e+06 2129.15 9.57242e+06 1932.35 9.04813e+06 891909 1.34968e+06 9.07801e+06 3.58669e+07
50733 20221004.49 11302.8 0 41283 0 10309.8 0 4629.42 0 3659.51 0 3528.68 0 6407.26 8.37592e+07 25129.1 19702.9 1.6126e+07 5622.39 1.56017e+07 2548.88 1.00967e+07 2142.41 9.31027e+06 1974.64 9.31027e+06 899977 1.37191e+06 9.4334e+06 3.56794e+07
50744 20221004.53 11708.1 0 42415.8 0 10739.6 0 4734.77 0 3668.15 0 3445.06 0 6435.09 8.37592e+07 23004.7 19748.7 1.66503e+07 5620.88 1.53396e+07 2544.22 1.00967e+07 2125.78 9.57242e+06 1932.03 9.04813e+06 881196 1.35557e+06 9.1797e+06 3.54939e+07
50750 20221005.2 10995.9 0 42222.6 0 10390.3 0 4411.31 0 3702.47 0 3361.3 0 6425.91 8.40213e+07 24517.4 19878 1.6126e+07 5602.38 1.56017e+07 2495.03 1.2456e+07 2156.45 9.31027e+06 1934.01 9.31027e+06 896628 1.37902e+06 9.29215e+06 3.58669e+07
50769 20221005.9 11479.8 0 42187.6 0 10099.3 0 4775.02 0 3871.36 0 3396.49 0 6336.03 8.37592e+07 24441 19590.3 1.6126e+07 5561.84 1.53396e+07 2556.91 9.83456e+06 2087.49 9.57242e+06 1932.5 9.31027e+06 906390 1.372e+06 9.27952e+06 3.59298e+07
50778 20221005.12 10740.1 0 40915.2 0 9954.33 0 4611.91 0 3703.39 0 3377.88 0 6251.58 8.24484e+07 24277.1 19490.6 1.63882e+07 5554.05 1.53396e+07 2473.42 1.00967e+07 2076.35 9.31027e+06 1917.35 9.31027e+06 904554 1.38444e+06 9.16331e+06 3.57417e+07
50792 20221005.18 11798.2 0 41437.3 0 10270 0 4675.05 0 3560.85 0 3487.7 0 6282.01 8.37592e+07 26504.4 19199.8 1.6126e+07 5599.88 1.56017e+07 2552.23 1.00967e+07 2122.44 9.57242e+06 1928.84 9.31027e+06 901454 1.35549e+06 9.20437e+06 3.58675e+07
50825 20221005.30 11066.8 0 43698.5 0 10655.7 0 4658.34 0 3695.34 0 3374.99 0 6228.44 8.74292e+07 25744.1 19719.2 1.63882e+07 5611.1 1.58639e+07 2604.78 9.83456e+06 2119.9 9.31027e+06 1938.39 9.04813e+06 872522 1.38023e+06 9.24601e+06 3.58663e+07
50850 20221006.2 11348 0 40797.1 0 10676 0 4688.94 0 3696.51 0 3384.5 0 6229.21 8.27106e+07 25559.2 19754.9 1.66503e+07 5579.31 1.53396e+07 2564.65 9.83456e+06 2109.84 9.31027e+06 1931.02 9.04813e+06 881004 1.37856e+06 9.23763e+06 3.58663e+07
50874 20221006.11 11531.7 0 44439.2 0 10249.9 0 4619.46 0 3646.48 0 3384.72 0 6294.18 8.66428e+07 27370.2 19492.6 1.69124e+07 5217.43 1.53396e+07 2536.76 1.00967e+07 2114.04 1.32424e+07 2006.22 9.04813e+06 894982 1.37182e+06 9.25436e+06 3.58036e+07
50933 20221006.28 10998.8 0 40651.3 0 10803.1 0 4648.81 0 3646.89 0 3371.18 0 5890.25 8.32349e+07 25695.2 19537.4 1.6126e+07 5546.49 1.56017e+07 2420.2 9.57242e+06 2099.96 9.57242e+06 1870.37 9.04813e+06 910257 1.37145e+06 9.32176e+06 3.56794e+07
50956 20221006.36 11200.8 0 43280.1 0 10641.9 0 4322.64 0 3504.67 0 3255.79 0 5869.76 8.27106e+07 21597.6 19647 1.66503e+07 5636.79 1.6126e+07 2480.09 9.57242e+06 2027.12 9.04813e+06 1877.18 9.04813e+06 889551 1.36072e+06 9.21273e+06 3.54325e+07
50972 20221006.42 10821.2 0 41526.4 0 10027.1 0 4574.86 0 3536.17 0 3237.04 0 5917.45 8.32349e+07 24266.6 19779.4 1.58639e+07 5562.98 1.53396e+07 2521.1 9.57242e+06 2068.4 9.31027e+06 1909.31 9.04813e+06 911390 1.37044e+06 9.10218e+06 3.56174e+07
50980 20221007.2 10868.3 0 41467.3 0 10087.3 0 4356.33 0 3414 0 3236.18 0 6218.71 8.3497e+07 25864.8 19358.1 1.6126e+07 5621.58 1.56017e+07 2426.73 9.57242e+06 2031.2 9.57242e+06 1874.24 9.04813e+06 901443 1.34745e+06 9.24184e+06 3.58669e+07
51011 20221007.12 11187.7 0 40597.2 0 10412.8 0 4314.43 0 3399.11 0 3294.19 0 6235.86 8.37592e+07 25389.5 19821 1.69124e+07 5548.36 1.56017e+07 2523.87 9.57242e+06 2059.07 9.31027e+06 1906.84 9.04813e+06 875619 1.37458e+06 9.04985e+06 3.58669e+07
51025 20221007.17 11467.1 0 41236.5 0 10121.7 0 4527.82 0 3615.67 0 3274.8 0 6310.28 8.32349e+07 24578.3 19793.5 1.71746e+07 5621.17 1.53396e+07 2419.48 9.83456e+06 2063.54 9.57242e+06 1918.97 9.04813e+06 895804 1.35574e+06 9.19615e+06 3.56174e+07

grpc_ccf

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
51019 20221007.14 11035.6 0 42815.3 0 10254.8 0 4332.85 0 3541.32 0 3380.87 0 23645.9 6216.63 8.37592e+07 19427.8 1.69124e+07 5646.11 1.56017e+07 2432.82 9.57242e+06 2039.58 9.04813e+06 1874.25 9.04813e+06 906109 1.36142e+06 9.22934e+06 3.58042e+07
51029 20221007.18 11405.1 0 43353.5 0 10368.5 0 4571.34 0 3433.51 0 3418.24 0 30676.1 6326.76 8.32349e+07 19759.9 1.63882e+07 5581.31 1.56017e+07 2415.9 9.57242e+06 2029.54 9.31027e+06 1951.97 9.04813e+06 913872 1.38294e+06 9.33451e+06 3.58669e+07

images

Copy link
Member

@MahatiC MahatiC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should instead rename the externalexecutor to remotedispatcher (or executordispatcher) in this PR or make a separate one for it. I think it would be good to have this reflect it, so that we comply with it in future code changes.

@eddyashton
Copy link
Member Author

I wonder if we should instead rename the externalexecutor to remotedispatcher (or executordispatcher) in this PR or make a separate one for it. I think it would be good to have this reflect it, so that we comply with it in future code changes.

I vote for a separate PR, though yes this is another place where it should be renamed!

@eddyashton eddyashton merged commit 738ee8c into microsoft:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate gRPC C++ types under a grpc namespace
3 participants