Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise error message on COSE msg type mismatch #4406

Closed
achamayou opened this issue Oct 26, 2022 · 0 comments · Fixed by #5019
Closed

More precise error message on COSE msg type mismatch #4406

achamayou opened this issue Oct 26, 2022 · 0 comments · Fixed by #5019
Assignees

Comments

@achamayou
Copy link
Member

    This error is very vague, and repeated in multiple places. I think they should mention that this is an issue with COSE signing, the name of the protected header it doesn't like, and the value it was expecting there.

That can be done in a follow-up though, not a blocker here.

(We could also push this check, and the one above about active members, into the auth policy itself? ie have multiple instances of the auth policy, and have an auth policy for this endpoint that checks this value of the protected header too? The advantage is moving more of the auth-like checks to the same place, with consistent error reporting. Downside is a massive increase in the number of auth policy instances if we make them too specific. Don't know where the right balance is there)

Originally posted by @eddyashton in #4392 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant