-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable COSE Sign1 authentication for governance endpoints #4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cose_authn_gov@52327 aka 20221026.33 vs main ewma over 20 builds from 51805 to 52321 Click to see tablemain
cose_authn_gov
|
achamayou
changed the title
Enabled COSE Sign1 authentication for governance endpoints
Enable COSE Sign1 authentication for governance endpoints
Oct 25, 2022
jumaffre
reviewed
Oct 25, 2022
jumaffre
reviewed
Oct 25, 2022
jumaffre
reviewed
Oct 25, 2022
jumaffre
reviewed
Oct 25, 2022
DomAyre
reviewed
Oct 26, 2022
eddyashton
reviewed
Oct 26, 2022
Co-authored-by: Dominic Ayre <domayre@outlook.com>
This was referenced Oct 26, 2022
eddyashton
approved these changes
Oct 26, 2022
DomAyre
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of #3875, with tests:
POST /gov/ack
POST /gov/proposals
POST /gov/proposals/{proposal_id}/ballots
POST /gov/proposals/{proposal_id}/withdraw
The change to
clients.py
to use COSE Sign1 is a bit of a bodge, but gets us a fair bit of coverage quickly. I will continue to clean up the implementation and the tests, but I think the interface is good to go for rc0.