-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playbook refactor to support App build and run containers #1178
Playbook refactor to support App build and run containers #1178
Conversation
app_containers_and_playbooks@8388 aka 20200515.10 vs master ewma over 50 builds from 7991 to 8377 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could we write a comment at the top of the app_ci
and app_run
Dockerfiles so that we/others can quickly find out which one to use depending on what they want to do?
@jumaffre yes, I need to expand the doc to cover the different scenarios, because the setup is also different depending on whether you want to build CCF itself or an app against a release. We also could/should put out a version against our nightly, for CI across repos. |
This needs a follow up PR to:
|
The goals for this PR are to:
ccfciteam/ccf-app-ci-18.04-oe-0.9:0.10
ccfciteam/ccf-app-run-18.04:0.10
In another PR, 1 and 2 will be hooked up to the release process, and will push those images automatically on release.