Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playbook refactor to support App build and run containers #1178

Merged
merged 10 commits into from
May 15, 2020
Merged

Playbook refactor to support App build and run containers #1178

merged 10 commits into from
May 15, 2020

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented May 14, 2020

The goals for this PR are to:

  1. Provide a complete CI docker image for CCF applications, using the latest release: ccfciteam/ccf-app-ci-18.04-oe-0.9:0.10
  2. Provide a lightweight runtime image for CCF applications, using the latest release ccfciteam/ccf-app-run-18.04:0.10
  3. Preserve the common playbook infra as much as possible, to make it easy to set up/upgrade dev machines/env for both CCF itself and CCF apps

In another PR, 1 and 2 will be hooked up to the release process, and will push those images automatically on release.

@ghost
Copy link

ghost commented May 14, 2020

app_containers_and_playbooks@8388 aka 20200515.10 vs master ewma over 50 builds from 7991 to 8377
images

@achamayou achamayou marked this pull request as ready for review May 14, 2020 15:15
@achamayou achamayou requested a review from a team as a code owner May 14, 2020 15:15
Copy link
Contributor

@jumaffre jumaffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we write a comment at the top of the app_ci and app_run Dockerfiles so that we/others can quickly find out which one to use depending on what they want to do?

@achamayou
Copy link
Member Author

@jumaffre yes, I need to expand the doc to cover the different scenarios, because the setup is also different depending on whether you want to build CCF itself or an app against a release.

We also could/should put out a version against our nightly, for CI across repos.

@achamayou
Copy link
Member Author

This needs a follow up PR to:

  1. Clean up README.md
  2. Establish different quickstart entry points for users who want to use CCF vs contribute to CCF
  3. Document the containers

@achamayou achamayou merged commit 02b6c84 into microsoft:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants