-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental KV type wrapper #1216
Merged
eddyashton
merged 39 commits into
microsoft:master
from
eddyashton:experimental_kv_type_wrapper
May 27, 2020
Merged
Add experimental KV type wrapper #1216
eddyashton
merged 39 commits into
microsoft:master
from
eddyashton:experimental_kv_type_wrapper
May 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
experimental_kv_type_wrapper@8714 aka 20200527.5 vs master ewma over 50 builds from 8543 to 8711 |
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
eddyashton
commented
May 26, 2020
achamayou
reviewed
May 26, 2020
jumaffre
reviewed
May 27, 2020
LGTM! |
achamayou
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft while I clean up some TODOs.
Continues refactor of KV, adding
kv::experimental::
alternatives tokv::
forMap
andTxView
types. Theexperimental::
variants wrap untyped (ie -std::vector<uint8_t> -> std::vector<uint8_t>
) instances of the old types, exposing the same interface (not just implementing the sameAbstract
types, but also matching template-discovered public typedefs) but implementing serialisation insideget
/put
etc.The eventual goal is to use these maps as standard, so
kv::Map
will becomekv::untyped::Map
, andkv::experimental::Map
will becomekv::Map
, with no visible API changes. For now they are experimental while I test the compatibility, and next I'll do a rollout testing them in existingMaps
.