-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C++ API to get untrusted host time #2550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_untrusted_time_api@24693 aka 20210504.4 vs main ewma over 20 builds from 24352 to 24682 Click to see table
|
ashamis
reviewed
May 3, 2021
ashamis
reviewed
May 3, 2021
ashamis
approved these changes
May 3, 2021
achamayou
approved these changes
May 4, 2021
jumaffre
approved these changes
May 4, 2021
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Aug 25, 2021
1 task
achamayou
pushed a commit
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2523.
Adds the API
get_untrusted_host_time_v1
, which returns the host-written (UTC) time as atimespec
.Also adds an example endpoint using this in the
nobuiltins
app, and a few test calls to confirm the reported time is close enough to the true time.