Remove unnecessary copies into OArray #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
replace_oarray@28636 aka 20210707.45 vs main ewma over 20 builds from 28245 to 28630 Click to see table
|
achamayou
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed as part of #2775:
We pass incoming messages in some places as
OArray&&, despite never using the abstraction it provides (a long-lived projection onto owned data). We can replace the ownership points with a plainstd::vector<uint8_t>, and where we pass it we can pass(data, size)(these could be refs if we had a pattern of read-modification that needed it, but we don't). The advantage of this is that when we're reading directly from an existing buffer (eg - we had(data, size)already pointing somewhere on the ringbuffer), we don't create an unnecessary copy into anOArray.