Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auth e2e test in V8 #3502

Merged
merged 13 commits into from
Feb 3, 2022
Merged

Conversation

eddyashton
Copy link
Member

@eddyashton eddyashton commented Feb 2, 2022

Part of #3314.

Draft for now, because this will need updating after #3498 is merged. - This is done, the fields added to the QuickJS implementation in #3498 are now also implemented in V8.

Includes part of #3324 - setting max heap size to same as QuickJS, but hit the same barriers that issue notes on setting a stack limit. For now, we just test that a (much larger) stack limit still applies to V8. - Gave up on this. Seems even the heap constraint has some platform-dependence that I'm missing, so the CI behaviour is different than local. Just disabled the limits test in V8 for now, with a comment pointing at #3324.

@ghost
Copy link

ghost commented Feb 2, 2022

enable_more_v8_tests@41168 aka 20220202.35 vs main ewma over 20 builds from 40911 to 41162

Click to see table

main

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
40911 20220131.30 6019.38 9.13613e+07 19381 1.6126e+07 5579.34 1.58639e+07 2527.89 1.00967e+07 1621.35 1.89927e+08 2200.02 1.03588e+07 1479.85 9.84392e+07 1973.9 9.31027e+06 20410.7 888460 1.36898e+06 9.20441e+06 3.58042e+07
40918 20220131.33 5989.98 9.13613e+07 19485.6 1.69124e+07 5639.18 1.56017e+07 2533.77 1.0621e+07 1649.9 1.89927e+08 2244.97 9.83456e+06 1473.81 9.81771e+07 1963.54 9.04813e+06 18211.3 917229 1.3781e+06 9.22934e+06 3.63114e+07
40929 20220201.2 5795.2 9.05749e+07 19364.5 1.82232e+07 5507.81 1.56017e+07 2469.32 1.0621e+07 1666.04 1.89665e+08 2200.34 1.00967e+07 1487.78 9.87014e+07 1972.42 9.31027e+06 18346.5 886460 1.38266e+06 9.4074e+06 3.58669e+07
40938 20220201.5 5989.69 8.97885e+07 19637.4 1.63882e+07 5717.49 1.53396e+07 2533.8 1.08831e+07 1635.79 1.89927e+08 2208.98 1.00967e+07 1473.43 9.81771e+07 1975.59 8.78598e+06 20619.4 893268 1.37412e+06 9.27952e+06 3.54325e+07
40953 20220201.10 6083.05 9.03128e+07 19652.2 1.69124e+07 5688.61 1.6126e+07 2575.78 1.03588e+07 1632.01 1.9019e+08 2195.32 1.00967e+07 1466.95 9.89635e+07 1969.37 9.83456e+06 18940.8 904306 1.36205e+06 9.15095e+06 3.59292e+07
40973 20220201.18 5843.84 8.97885e+07 19730.2 1.6126e+07 5667.09 1.56017e+07 2518.73 1.00967e+07 1616.33 1.9019e+08 2156.37 9.83456e+06 1473.42 9.87014e+07 1966.97 9.04813e+06 19924 910373 1.38097e+06 9.26684e+06 3.54939e+07
40995 20220201.26 5984.86 9.08371e+07 19355.1 1.69124e+07 5596.81 1.6126e+07 2530.17 1.0621e+07 1609.98 1.89665e+08 2196.6 1.00967e+07 1451.24 9.89635e+07 1965.02 1.14074e+07 17679.2 899305 1.37745e+06 9.30478e+06 3.63121e+07
41007 20220201.30 5899.98 9.03128e+07 19797.8 1.6126e+07 5686.43 1.6126e+07 2537.55 1.0621e+07 1638.69 1.90452e+08 2164.26 1.00967e+07 1477.45 9.87014e+07 1967.12 1.14074e+07 19747.2 923555 1.37791e+06 9.39445e+06 3.65714e+07
41024 20220201.38 5983.89 9.10992e+07 19688.9 1.63882e+07 5484.52 1.58639e+07 2530.08 1.03588e+07 1630.52 1.89665e+08 2199.25 1.03588e+07 1471.38 9.81771e+07 1967.54 9.83456e+06 19869.3 898753 1.3676e+06 9.36862e+06 3.59298e+07
41043 20220201.46 5881.6 9.00506e+07 19759.3 1.71746e+07 5761.04 1.56017e+07 2590.68 1.0621e+07 1642 1.87568e+08 2109.62 1.00967e+07 1448.03 9.84392e+07 1982.02 9.31027e+06 20187.3 909771 1.36943e+06 9.34302e+06 3.57417e+07
41046 20220201.47 5833.22 9.13613e+07 19687.4 1.63882e+07 5657.52 1.56017e+07 2576.18 1.00967e+07 1605.2 1.89403e+08 2232.86 9.57242e+06 1459.87 9.84392e+07 1969.05 9.31027e+06 17892.9 913702 1.38601e+06 9.34294e+06 3.58669e+07
41060 20220201.54 6036.12 9.10992e+07 19792.6 1.66503e+07 5704.08 1.56017e+07 2485.25 1.03588e+07 1644.29 1.87044e+08 2208.1 9.83456e+06 1472.28 9.89635e+07 1971.75 9.04813e+06 20841.8 892369 1.35998e+06 9.19206e+06 3.50685e+07
41071 20220201.59 5910.26 8.95263e+07 19140.8 1.63882e+07 5388.08 1.6126e+07 2593.46 1.00967e+07 1610.06 1.89403e+08 2201.23 1.14074e+07 1480.03 9.87014e+07 1973.75 9.04813e+06 20625.4 887074 1.38368e+06 9.30055e+06 3.54319e+07
41085 20220202.3 6052.07 9.03128e+07 19980.3 1.63882e+07 5608.61 1.58639e+07 2584.08 1.0621e+07 1656.48 1.87568e+08 2209.67 1.00967e+07 1503.86 9.84392e+07 1972.89 9.31027e+06 20646.1 898278 1.40794e+06 9.37291e+06 3.64413e+07
41091 20220202.5 5891.57 9.00506e+07 19717.7 1.6126e+07 5611.16 1.56017e+07 2649.09 1.00967e+07 1612.76 1.89665e+08 2166.99 1.00967e+07 1466.76 9.87014e+07 1968.09 9.31027e+06 19929 917024 1.38284e+06 9.27952e+06 3.64413e+07
41096 20220202.7 5981.87 9.00506e+07 20071.3 1.66503e+07 5537.82 1.53396e+07 2637.65 1.03588e+07 1622.36 1.9019e+08 2164.26 9.83456e+06 1477.6 9.87014e+07 1959.64 9.57242e+06 22218.9 903352 1.38743e+06 9.39445e+06 3.58669e+07
41128 20220202.21 5978.12 9.08371e+07 19885.9 1.69124e+07 5569.38 1.6126e+07 2579.21 1.03588e+07 1629.31 1.89927e+08 2210.58 1.00967e+07 1467.82 9.87014e+07 1904.7 9.57242e+06 22077.1 889661 1.38043e+06 9.22523e+06 3.58669e+07
41136 20220202.24 6084.76 9.13613e+07 19661.2 1.63882e+07 5356.33 1.63882e+07 2506.22 1.03588e+07 1600.11 1.89141e+08 2143.88 9.83456e+06 1480.21 9.66042e+07 1968.54 9.57242e+06 20152.3 875248 1.3756e+06 9.39019e+06 3.64413e+07
41152 20220202.30 6011.13 9.08371e+07 19563.4 1.58639e+07 5630.34 1.56017e+07 2527.47 1.0621e+07 1636.39 1.89665e+08 2160.47 1.00967e+07 1468.14 9.84392e+07 1972.55 9.31027e+06 18179.9 881388 1.34719e+06 9.27116e+06 3.56794e+07
41162 20220202.33 6017.56 9.00506e+07 19678 1.63882e+07 5719.58 1.6126e+07 2537.08 1.27181e+07 1634.58 1.9019e+08 2165.3 1.00967e+07 1477.91 9.89635e+07 1960.86 9.57242e+06 20106.4 884773 1.38462e+06 9.24601e+06 3.49488e+07

enable_more_v8_tests

build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
41140 20220202.25 5962.73 8.97885e+07 19662.6 1.66503e+07 5677.29 1.58639e+07 2533.42 1.0621e+07 1509.33 1.92549e+08 2158.72 1.00967e+07 1393.42 1.85471e+08 1963.71 8.78598e+06 17916.7 901959 1.37182e+06 9.38154e+06 3.5128e+07
41168 20220202.35 5941.16 9.16235e+07 19574 1.66503e+07 5617.14 1.58639e+07 2521.85 1.03588e+07 1629.66 1.645e+08 2159.7 9.83456e+06 1464.61 9.89635e+07 1934.12 9.31027e+06 18346.6 889689 1.37494e+06 9.23346e+06 3.54933e+07

images

@eddyashton eddyashton marked this pull request as ready for review February 2, 2022 17:51
@eddyashton eddyashton requested a review from a team February 2, 2022 17:51
@eddyashton eddyashton merged commit 0208ca2 into microsoft:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants