-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable auth e2e test in V8 #3502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable_more_v8_tests@41168 aka 20220202.35 vs main ewma over 20 builds from 40911 to 41162 Click to see tablemain
enable_more_v8_tests
|
achamayou
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3314.
Draft for now, because this will need updating after #3498 is merged.- This is done, the fields added to the QuickJS implementation in #3498 are now also implemented in V8.Includes part of #3324 - setting max heap size to same as QuickJS, but hit the same barriers that issue notes on setting a stack limit. For now, we just test that a (much larger) stack limit still applies to V8.- Gave up on this. Seems even the heap constraint has some platform-dependence that I'm missing, so the CI behaviour is different than local. Just disabled thelimits
test in V8 for now, with a comment pointing at #3324.