Add endpoint to get previous service identity #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
prev_ident_endpoint@46279 aka 20220608.15 vs main ewma over 20 builds from 46009 to 46221 Click to see tablemain
prev_ident_endpoint
|
jumaffre
reviewed
May 24, 2022
jumaffre
reviewed
May 24, 2022
jumaffre
approved these changes
May 24, 2022
|
@jumaffre and I noticed some other issues around this, so I'm fixing those as well before merging. |
jumaffre
approved these changes
May 25, 2022
achamayou
reviewed
May 25, 2022
achamayou
approved these changes
May 25, 2022
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
…prev_ident_endpoint
…prev_ident_endpoint
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Jun 9, 2022
achamayou
pushed a commit
that referenced
this pull request
Jun 10, 2022
shokouedamsr
added
the
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
/node/network/previous_identityendpoint.This only works in a node started asRecover, and reads the identity-of-the-previous-service passed to this node on startup. That's simpler than writing it to the KV to be shared to all nodes, and reasoning about the edge cases that introduces (nodes having the wrong value while they're catching up).EDIT - This is now written to the KV in the recovery-genesis transaction, so can be read by all nodes. Also tested in e2e recovery tests.
Resolves #3879.