Safe node removal #4008
Merged
Safe node removal #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
safe_node_removal@48093 aka 20220728.7 vs main ewma over 20 builds from 47853 to 48083 Click to see tablemain
safe_node_removal
|
…into safe_node_removal
|
Some notes for Monday: Interestingly, the LTS fails with: Occurring in a 2.0.4 node, which suggests that a new node is sending messages the old nodes are unable to cope with. I was initially suspicious that this may be because the nodes are removed from the table too early, and signature verification fails, but removing the node removal call reveals that is not the case! |
|
The LTS break is caused by the enum extension causing a deserialisation break on the older nodes. The fix, discussed with @eddyashton is to remove the additional state and use a boolean flag instead. |
achamayou
commented
Jul 25, 2022
jumaffre
reviewed
Jul 26, 2022
jumaffre
reviewed
Jul 26, 2022
jumaffre
reviewed
Jul 26, 2022
jumaffre
reviewed
Jul 26, 2022
jumaffre
reviewed
Jul 26, 2022
jumaffre
approved these changes
Jul 28, 2022
eddyashton
approved these changes
Jul 28, 2022
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
achamayou
added a commit
to achamayou/CCF
that referenced
this pull request
Jul 28, 2022
achamayou
added a commit
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1713
retired_committednode flag in the KV. Nodes are transitioned to this flag being set by the primary observing that theirRETIREDstate for them has been committed.GET /node/network/removable_nodesendpoint to queryRETIRED && retired_committednodes - this allows the operator to find out what nodes can be safely shut downRETIRED && retired_committednodes from the KV to avoid KV growthWe may choose to go with a "fresh read" for step 2 instead, removing the need for step 3 and allowing us to elide the
retired_committedstep and go straight to removal. This involves turningGET /node/network/removable_nodesinto a write, for which operators would need to not forget to checktx/status. This seems unergonomic right now.Once we have blocking transactions though, we probably want to revisit this.