Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move libprotobuf to exported 3rdparty dependency #4227

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

jumaffre
Copy link
Contributor

Part of 1. in #4211

Move libprotobuf from internal to exported dependencies so that app developers can serialise/deserialise protobuf payloads (useful for gRPC).

Next: Move gRPC wrappers to libccf_endpoints.

@jumaffre jumaffre requested a review from a team September 13, 2022 16:12
@ghost
Copy link

ghost commented Sep 13, 2022

move_libprotobuf@49813 aka 20220915.15 vs main ewma over 20 builds from 49512 to 49807

Click to see table

main

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_v8_virtual_cft^ ls_v8_virtual_cft_mem tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_full_v8_virtual_cft^ ls_full_v8_virtual_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
49512 20220909.14 10808.7 0 43195.6 0 10427.1 0 4781.33 0 2725.07 0 6345.64 8.37592e+07 3771.74 0 19628.7 1.66503e+07 2440.82 0 5590.22 1.56017e+07 3637.08 0 2500.39 9.83456e+06 31282.1 1606.46 1.67121e+08 2115.8 9.57242e+06 1392.44 9.81771e+07 1934.31 1.08831e+07 897053 1.37799e+06 9.22514e+06 3.58663e+07
49527 20220909.20 11283.9 0 40754.8 0 10726.7 0 4698.84 0 2761.97 0 6344.24 8.21863e+07 3686.62 0 19683.7 1.66503e+07 2497.39 0 5544.58 1.56017e+07 3696.51 0 2556.36 9.83456e+06 29582.5 1580.21 1.64762e+08 2117.13 9.57242e+06 1381.84 9.79149e+07 1929.75 9.31027e+06 900451 1.3561e+06 9.49018e+06 3.58669e+07
49550 20220909.26 11156.1 0 41319.1 0 10021.3 0 4700.23 0 2818.99 0 6318.42 8.40213e+07 3686.21 0 19713.8 1.6126e+07 2488.34 0 5607.74 1.58639e+07 3385.55 0 2563.5 1.03588e+07 21625.8 1580.96 1.67121e+08 2086.42 9.57242e+06 1407.08 9.76528e+07 1927.31 9.31027e+06 900851 1.37422e+06 9.22107e+06 3.58669e+07
49564 20220912.2 11614.1 0 41461.4 0 10442.9 0 4767.08 0 2829.87 0 6189.17 8.32349e+07 3676.69 0 19626.8 1.66503e+07 2487.63 0 5597.1 1.53396e+07 3502.76 0 2536.6 1.03588e+07 24945 1587.5 1.66859e+08 2150.63 1.21939e+07 1392.93 9.79149e+07 1896.21 9.31027e+06 894738 1.37098e+06 9.22926e+06 3.59292e+07
49569 20220912.4 11354.2 0 42977.9 0 10169.1 0 4780.73 0 2805.3 0 6431.28 8.32349e+07 3740.43 0 19872.6 1.6126e+07 2500.98 0 5667.34 1.56017e+07 3381.8 0 2488.03 1.00967e+07 23732.5 1612.69 1.66859e+08 2152.87 9.57242e+06 1409.99 9.84392e+07 1934.5 9.31027e+06 888574 1.37347e+06 9.21269e+06 3.57411e+07
49593 20220912.12 11455.1 0 43135.2 0 10806.9 0 4740.1 0 2871.8 0 6375.97 8.27106e+07 3568.25 0 19825.9 1.66503e+07 2510.38 0 5654.07 1.56017e+07 3706.8 0 2557.47 1.03588e+07 24354.5 1587.65 1.67121e+08 2125.26 9.31027e+06 1419.87 9.73907e+07 1935.59 9.31027e+06 890855 1.37182e+06 9.19202e+06 3.59298e+07
49603 20220912.15 10811.5 0 41637.4 0 10117.3 0 4687 0 2762.17 0 6389.28 8.3497e+07 3698.93 0 19645.4 1.66503e+07 2485.93 0 5606.08 1.56017e+07 3361.27 0 2546.82 1.00967e+07 23866.9 1615.04 1.67383e+08 2126.82 9.31027e+06 1421.76 9.84392e+07 1937.82 9.04813e+06 906793 1.37959e+06 9.27532e+06 3.58663e+07
49617 20220913.2 10617.9 0 40363.8 0 10111 0 4736.87 0 2738.79 0 6358.4 8.37592e+07 3682.65 0 19962.4 1.6126e+07 2471.31 0 5693.62 1.58639e+07 3400.66 0 2551.15 1.00967e+07 26173.4 1594.77 1.65024e+08 2085.2 9.31027e+06 1384.22 9.79149e+07 1935.22 9.31027e+06 903191 1.38424e+06 9.25851e+06 3.58669e+07
49627 20220913.7 10597.4 0 41276.1 0 10176.7 0 4701.33 0 2740 0 6446.43 8.3497e+07 3571.34 0 19916.4 1.63882e+07 2474.99 0 5595.4 1.56017e+07 3402.12 0 2480.2 1.03588e+07 24563.4 1622.35 1.67383e+08 2118.6 9.57242e+06 1430.17 9.87014e+07 1974.36 9.31027e+06 905113 1.37551e+06 9.27957e+06 3.58669e+07
49639 20220913.12 11419.2 0 42190 0 10610.2 0 4639.08 0 2835.13 0 6537.69 8.40213e+07 3693.27 0 19955.1 1.6126e+07 2456.25 0 5628.38 1.56017e+07 3394.72 0 2490.85 9.83456e+06 29629.1 1626.34 1.67121e+08 2158.67 9.57242e+06 1429.25 9.68664e+07 1942.8 9.31027e+06 906231 1.37338e+06 9.22103e+06 3.58669e+07
49643 20220913.14 10874 0 42810 0 10237 0 4754.9 0 2863.04 0 6381.05 8.27106e+07 3674.02 0 19982.1 1.69124e+07 2495.32 0 5620.07 1.53396e+07 3366.39 0 2610.83 1.00967e+07 21475.2 1587.91 1.66597e+08 2122.94 9.57242e+06 1420.49 9.84392e+07 1942.61 9.31027e+06 910337 1.37772e+06 9.3772e+06 3.58669e+07
49689 20220913.28 11062.8 0 43352.7 0 10775.9 0 4579.82 0 2856.23 0 6279.68 8.37592e+07 3807.02 0 19663.3 1.66503e+07 2509.17 0 5596.78 1.56017e+07 3361.94 0 2491.91 1.00967e+07 25718.5 1589.71 1.66859e+08 2076.59 9.83456e+06 1404.79 9.73907e+07 1931.34 9.31027e+06 927744 1.38988e+06 9.33876e+06 3.55556e+07
49692 20220914.1 11041.4 0 41183.7 0 10588.9 0 4709.74 0 2787.26 0 6297.11 8.27106e+07 3585.85 0 19619.9 1.63882e+07 2409.29 0 5607.48 1.6126e+07 3399 0 2553.09 1.03588e+07 28625.2 1630.84 1.66859e+08 2085.39 9.57242e+06 1408.36 9.81771e+07 1925.89 9.57242e+06 925058 1.37912e+06 9.25432e+06 3.58042e+07
49714 20220914.11 10911.8 0 43136.5 0 10762.3 0 4682.37 0 2800.04 0 6299.8 8.27106e+07 3566.48 0 19755.4 1.63882e+07 2470.11 0 5583.41 1.58639e+07 3416.69 0 2491.68 1.03588e+07 29186.1 1603.35 1.66859e+08 2118.39 9.83456e+06 1410.77 9.79149e+07 1935.32 1.08831e+07 904267 1.37596e+06 9.25014e+06 3.58663e+07
49731 20220914.17 11020.9 0 41042.7 0 10480.1 0 4725.14 0 2739.87 0 6196.93 8.37592e+07 3720.46 0 19750.4 1.71746e+07 2440.71 0 5595.67 1.58639e+07 3698.6 0 2613.01 1.00967e+07 26078.2 1604.51 1.66597e+08 2115.26 9.83456e+06 1415.47 9.84392e+07 1935.06 9.31027e+06 908117 1.38734e+06 9.28794e+06 3.59298e+07
49760 20220914.27 10360.1 0 41160.4 0 10416.5 0 4664.21 0 2746.27 0 6355.48 8.40213e+07 3499.24 0 19728.7 1.63882e+07 2525.31 0 5630.86 1.58639e+07 3358.9 0 2537.35 1.03588e+07 26832.4 1599.15 1.66859e+08 2078 9.57242e+06 1417.74 9.81771e+07 1938.05 9.31027e+06 897728 1.33541e+06 9.51222e+06 3.56794e+07
49773 20220914.32 10967.9 0 42018.7 0 10647.4 0 4581.5 0 2720.89 0 6342.1 8.61185e+07 3579.15 0 20010.9 1.63882e+07 2444.41 0 5650.13 1.56017e+07 3382.17 0 2548.15 1.0621e+07 22572.3 1597.03 1.67121e+08 2127.77 9.57242e+06 1409.6 9.81771e+07 1926.41 9.31027e+06 909367 1.39262e+06 9.25851e+06 3.58669e+07
49783 20220915.1 11668.9 0 41768.2 0 10638.3 0 4771.95 0 2931.86 0 6208.67 8.3497e+07 3706.87 0 19703.3 1.63882e+07 2546.25 0 5525.56 1.56017e+07 3562.14 0 2497.86 9.83456e+06 27378.2 1566.66 1.67383e+08 2038.6 9.57242e+06 1414.69 9.84392e+07 1926.63 9.31027e+06 910374 1.37504e+06 9.21269e+06 3.58042e+07
49788 20220915.4 11432 0 40934.7 0 10649.8 0 4777.09 0 2896.33 0 6446.6 8.66428e+07 3603.65 0 20001.1 1.66503e+07 2598.33 0 5658.84 1.53396e+07 3451.38 0 2533.12 1.00967e+07 25071 1605.46 1.66859e+08 2026.81 9.31027e+06 1412.48 9.79149e+07 1944.69 9.31027e+06 903026 1.38171e+06 9.20441e+06 3.63766e+07
49807 20220915.13 11038.2 0 41980.2 0 10245.8 0 4619.41 0 2764.62 0 6319.06 8.29727e+07 3789.7 0 19783.5 1.6126e+07 2433.48 0 5603.23 1.6126e+07 3661.33 0 2409.94 1.27181e+07 27827.4 1574.95 1.66859e+08 2162.76 9.31027e+06 1407.08 9.81771e+07 1921.65 9.31027e+06 902033 1.37172e+06 9.29637e+06 3.58036e+07

move_libprotobuf

build_id build_number tpcc_virtual_cft^ tpcc_virtual_cft_mem ls_virtual_cft^ ls_virtual_cft_mem ls_jwt_virtual_cft^ ls_jwt_virtual_cft_mem ls_js_virtual_cft^ ls_js_virtual_cft_mem ls_v8_virtual_cft^ ls_v8_virtual_cft_mem ls_full_js_virtual_cft^ ls_full_js_virtual_cft_mem ls_full_v8_virtual_cft^ ls_full_v8_virtual_cft_mem ls_js_jwt_virtual_cft^ ls_js_jwt_virtual_cft_mem hist_sgx_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_v8_sgx_cft^ ls_v8_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_full_v8_sgx_cft^ ls_full_v8_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
49684 20220913.26 11265 0 41695.4 0 10268.4 0 4689.36 0 2789.57 0 3693.02 0 2450.6 0 3698.17 0 24669.2 6313.8 8.37592e+07 19692.6 1.66503e+07 5586.13 1.56017e+07 2551.93 1.03588e+07 1580.55 1.66859e+08 2117.03 9.57242e+06 1406.17 9.81771e+07 1967.74 9.04813e+06 909609 1.37495e+06 9.22099e+06 3.58669e+07
49770 20220914.30 10709.5 0 39088.5 0 10631 0 4722.76 0 2803.57 0 3640.83 0 2426.29 0 3386.67 0 25891.1 6470.08 8.3497e+07 19791.2 1.6126e+07 5650.88 1.58639e+07 2558.84 1.00967e+07 1612.96 1.66859e+08 2121.22 9.31027e+06 1414.9 9.81771e+07 1923.92 9.31027e+06 911107 1.37958e+06 9.38154e+06 3.54325e+07
49796 20220915.7 11479.6 0 44418.4 0 10637.3 0 4635.69 0 2885.74 0 3707.69 0 2549.7 0 3581.78 0 25670.4 6513.92 8.3497e+07 19545.2 1.66503e+07 5653.34 1.58639e+07 2558.11 1.00967e+07 1620.34 1.65024e+08 2164.92 9.57242e+06 1411.78 9.81771e+07 1940.25 9.31027e+06 907468 1.3767e+06 9.24179e+06 3.51884e+07
49798 20220915.8 10850.7 0 43973.1 0 10271.8 0 4752.73 0 2792.94 0 3547.98 0 2440.97 0 3391.03 0 23313.5 6356.94 8.32349e+07 19859.8 1.66503e+07 5590.47 1.58639e+07 2496.44 1.03588e+07 1589.73 1.66859e+08 2116.69 9.57242e+06 1389.24 9.92257e+07 1934.24 9.04813e+06 912609 1.38659e+06 9.14278e+06 3.58669e+07
49813 20220915.15 11454.7 0 43923.2 0 10241.3 0 4682.74 0 2869.5 0 3597.92 0 2600.74 0 3554.73 0 29827.8 6525.99 8.32349e+07 19985.1 1.69124e+07 5688.64 1.56017e+07 2509.37 1.00967e+07 1606.2 1.66859e+08 2130.5 9.57242e+06 1427.97 9.87014e+07 1839.15 9.31027e+06 913629 1.36405e+06 9.15508e+06 3.58042e+07

images

@eddyashton eddyashton merged commit f449530 into microsoft:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants