Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unintended time checks from node-to-node validation #4733

Merged
merged 20 commits into from
Dec 13, 2022
Merged

Remove unintended time checks from node-to-node validation #4733

merged 20 commits into from
Dec 13, 2022

Conversation

eddyashton
Copy link
Member

The node-to-node channels should be based purely on public key identities, and not care about certificate expiry times. They were including a time check during validation, and they no longer do.

Includes unit tests and a partitioning end-to-end test.

@eddyashton eddyashton requested a review from a team December 13, 2022 13:55
achamayou
achamayou reviewed Dec 13, 2022
View reviewed changes
achamayou
achamayou reviewed Dec 13, 2022
View reviewed changes
achamayou
achamayou reviewed Dec 13, 2022
View reviewed changes
achamayou
achamayou approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@achamayou achamayou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog entry would be good, with a mention of the error message users were liable to encounter when they hit this issue.

@ghost
Copy link

ghost commented Dec 13, 2022 •
edited by ghost
Loading

node_to_node_validation_timeless@57993 aka 20221213.59 vs main ewma over 20 builds from 57258 to 57967

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
57258 20221207.19 0.783571 17170.4 46094.8 6294.23 8.21863e+07 15454.8 1.50774e+07 45117.1 15556.4 8.78598e+06 14040.3 12504.7 4479.58 3562.47 3367.69 5856.3 7.47526e+06 5697.71 1.48153e+07 23494.1 1554.25 7.99955e+06 1288.43 7.47526e+06 1297.18 6.95098e+06 831021 1.18074e+06 8.15306e+06 3.17593e+07
57352 20221207.40 0.777018 17327.1 43588 6321.08 8.21863e+07 15513.2 1.50774e+07 44950.5 15535.9 8.52384e+06 14000.5 13869.9 4574.3 3498.99 3468.39 5793.2 8.2617e+06 5678.24 1.4291e+07 26210.8 1570.97 7.99955e+06 1286.33 7.99955e+06 1294.01 7.21312e+06 793880 1.17615e+06 8.14606e+06 3.17761e+07
57497 20221208.19 0.77788 17341.8 43923.6 6296.96 8.24484e+07 15304.8 1.50774e+07 47558.8 15518.5 8.78598e+06 13270.2 12509.8 4447.01 3663.03 3484.08 5854.1 7.21312e+06 5854.49 1.53396e+07 22388.7 1566.81 7.99955e+06 1288.2 7.99955e+06 1307.97 7.21312e+06 835875 1.17822e+06 8.15429e+06 3.1249e+07
57514 20221208.23 0.786024 17166.7 43803.7 6335.16 8.27106e+07 15440.4 1.50774e+07 44691.6 15528.3 8.78598e+06 14107.5 12566.4 4566.39 3677.88 3429.24 5823 7.47526e+06 5886.13 1.53396e+07 23022 1567.88 7.99955e+06 1288.49 7.47526e+06 1305.99 6.95098e+06 834150 1.17979e+06 8.04134e+06 3.07882e+07
57575 20221208.40 0.757691 17522.3 48265 6345.34 8.29727e+07 15478.3 1.50774e+07 45168.4 15508.1 8.78598e+06 14208.6 12485.6 4552.48 3556.59 3458.1 5808.8 7.73741e+06 5874.94 1.53396e+07 22964.9 1566.48 7.99955e+06 1290.16 7.99955e+06 1303.72 7.21312e+06 831599 1.17802e+06 8.15628e+06 3.07651e+07
57584 20221209.2 0.78448 17530.6 43951.5 6282.45 8.21863e+07 15363 1.6126e+07 47452.4 15481 8.78598e+06 13259.8 14092.9 4366.84 3525.13 3496.66 5795.2 7.73741e+06 5807.67 1.53396e+07 27357.2 1556.1 7.99955e+06 1286.1 7.47526e+06 1300.71 7.21312e+06 831868 1.18326e+06 8.15079e+06 3.08063e+07
57612 20221209.10 0.783278 17485.6 45764.4 6328.1 8.27106e+07 15464 1.53396e+07 47107 15528.6 8.78598e+06 14228.5 12401.9 4502.52 3521.64 3440.94 5808.9 7.21312e+06 5836.55 1.53396e+07 28844.9 1560.12 7.99955e+06 1284.84 7.47526e+06 1286.07 7.21312e+06 839803 1.17423e+06 8.13923e+06 3.0829e+07
57631 20221209.16 0.769375 17341.6 43665.4 6252.83 8.19242e+07 15421.6 1.58639e+07 46388.6 15520.9 8.52384e+06 13046.9 12589 4461.23 3513.64 3350.53 5822.4 7.73741e+06 5791.83 1.53396e+07 28237.3 1567.46 7.99955e+06 1286.85 7.47526e+06 1305.43 7.21312e+06 836299 1.17598e+06 8.15089e+06 3.07873e+07
57661 20221209.24 0.786548 17305.2 44036 6346.77 8.24484e+07 15416.6 1.53396e+07 46948.5 15471.5 8.78598e+06 14083.5 12406.5 4592.87 3525.53 3309.58 5769.6 6.95098e+06 5818.07 1.50774e+07 25035.2 1560.78 7.99955e+06 1279.87 7.21312e+06 1283.14 7.21312e+06 827958 1.17771e+06 8.17402e+06 3.06069e+07
57709 20221212.3 0.768848 17469.6 45964.8 6316.67 8.27106e+07 15541.1 1.50774e+07 47218.5 15487.8 8.78598e+06 13863.6 12932.9 4409.75 3545.97 3283.75 5876.5 6.68883e+06 5853.62 1.53396e+07 22507.1 1564.18 7.99955e+06 1287.05 7.47526e+06 1293.65 7.21312e+06 830076 1.1791e+06 8.13428e+06 3.07531e+07
57731 20221212.11 0.760781 17519.4 43913.6 6302.7 8.27106e+07 15496.3 1.53396e+07 47662.1 15587.2 8.52384e+06 14091.2 12532.5 4521.8 3539.52 3433.59 5813.3 6.95098e+06 5822.37 1.48153e+07 23930.6 1565.51 7.99955e+06 1284.63 7.47526e+06 1295.33 7.21312e+06 835119 1.17422e+06 8.154e+06 3.07314e+07
57750 20221212.16 0.800014 17395.2 43784.2 6327.65 8.24484e+07 15382.8 1.53396e+07 47121.4 15450.6 8.52384e+06 13945.5 12466.7 4554.56 3688.29 3426.81 5814.6 7.21312e+06 5780.04 1.53396e+07 22168.7 1569.46 7.99955e+06 1293.77 7.47526e+06 1307.33 7.21312e+06 832288 1.18152e+06 8.14078e+06 3.12e+07
57770 20221212.23 0.769973 17468 48044.1 6267.59 8.21863e+07 15420.8 1.50774e+07 44756.4 15479.2 8.78598e+06 13182.6 12366 4504.27 3524.18 3332.77 5831.2 7.21312e+06 5831.11 1.53396e+07 27061.6 1565.58 7.99955e+06 1285.99 7.73741e+06 1289.86 6.95098e+06 808729 1.16155e+06 8.15141e+06 3.14458e+07
57780 20221212.26 0.768107 17259 48188.8 6253.49 8.24484e+07 15422.1 1.50774e+07 47111.4 15468.6 8.78598e+06 13767.6 12397.4 4469.91 3684.63 3445.95 5803.9 7.21312e+06 5809.98 1.50774e+07 23546.6 1566.41 7.99955e+06 1280.77 7.21312e+06 1289.3 7.21312e+06 828365 1.17822e+06 8.13541e+06 3.1529e+07
57788 20221213.1 0.770024 17717.2 44036.9 6291.26 8.21863e+07 15568 1.53396e+07 46316.2 15611.1 8.52384e+06 13186.7 12490.6 4519.51 3586.5 3421.02 5828.5 7.99955e+06 5621 1.4291e+07 24374.4 1568.15 7.99955e+06 1288.65 7.47526e+06 1308.88 7.21312e+06 833925 1.17887e+06 8.1565e+06 3.08489e+07
57807 20221213.7 0.776065 17301.2 45803.8 6318.74 8.13999e+07 15554.2 1.50774e+07 46496.2 15556.4 8.78598e+06 13129.6 12428 4514.25 3556.77 3519.18 5851.3 7.47526e+06 5635.24 1.45532e+07 23406.9 1568.9 7.99955e+06 1288.28 7.73741e+06 1297.5 7.21312e+06 835897 1.18519e+06 8.17284e+06 3.07272e+07
57842 20221213.16 0.766579 17643.6 45917.4 6312.62 8.27106e+07 15471.7 1.53396e+07 44838.3 15585.7 8.78598e+06 14036.9 12602.6 4470.82 3682.72 3513.42 5858 6.95098e+06 5888.6 1.48153e+07 23974.3 1567.55 7.99955e+06 1289.59 7.47526e+06 1309.74 7.21312e+06 830352 1.18086e+06 8.17059e+06 3.0778e+07
57905 20221213.32 0.813671 17173.9 45769.1 6296.64 8.21863e+07 15499.3 1.53396e+07 45710.7 15467 8.78598e+06 14169.6 14092.6 4550.78 3533.51 3461.89 5831.7 6.68883e+06 5818.2 1.50774e+07 21622.8 1572.18 7.73741e+06 1281.57 7.21312e+06 1279.52 6.95098e+06 831250 1.17613e+06 8.17252e+06 3.0791e+07
57931 20221213.41 0.785537 17123.4 45924.4 6267.43 8.27106e+07 15709.5 1.53396e+07 45854.9 15660.4 8.52384e+06 13286.9 14051 4625.12 3692.99 3454.7 5837.6 6.68883e+06 5838.08 1.50774e+07 23163.7 1570.7 7.73741e+06 1294.99 7.73741e+06 1293.53 6.95098e+06 835261 1.18015e+06 8.13641e+06 3.08137e+07
57967 20221213.52 0.761508 17161.7 43775.2 6339.49 8.21863e+07 15643.8 1.50774e+07 44567.7 15597 8.78598e+06 13236.2 12490.4 4645.9 3663.13 3432.87 5856.8 6.68883e+06 5817.83 1.50774e+07 24572.1 1575.7 7.73741e+06 1285.81 7.21312e+06 1300.81 6.95098e+06 834640 1.17501e+06 8.16564e+06 3.07877e+07

node_to_node_validation_timeless

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
57942 20221213.44 0.78649 17235.9 43852.5 46630.4 6310.28 8.21863e+07 15681.9 1.50774e+07 15658.2 8.78598e+06 14105.9 12345.2 4362.41 3656.18 5825 6.68883e+06 3315.86 5809.31 1.48153e+07 1565.6 7.73741e+06 24838.6 1284.71 7.73741e+06 1295.25 6.95098e+06 830830 1.17813e+06 8.04077e+06 3.1109e+07
57993 20221213.59 0.826176 17074 43612.5 46349.3 6330.23 8.29727e+07 15673.9 1.53396e+07 15615.3 8.78598e+06 12982.6 12829.8 4537.26 3555.32 5862.1 6.68883e+06 3281.12 5875.32 1.50774e+07 1575.83 7.73741e+06 22708 1288.18 7.47526e+06 1298.5 6.95098e+06 831579 1.17975e+06 8.17004e+06 3.12801e+07

images

@eddyashton eddyashton added 2.x-todo PRs which should be backported to 2.x auto-backport Automatically backport this PR to LTS branch 3.x-todo PRs which should be backported to 3.x labels Dec 13, 2022
@eddyashton eddyashton merged commit 1ebcd07 into microsoft:main Dec 13, 2022
@github-actions
Copy link

💔 All backports failed

Status Branch Result
❌ release/2.x Backport failed because of merge conflicts

You might need to backport the following PRs to release/2.x:
- Session consistency: Parse forwarded messages with consistency info (#4595)
❌ release/3.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 4733

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@eddyashton eddyashton mentioned this pull request Dec 13, 2022
Merged
@eddyashton eddyashton added the backported This PR was successfully backported to LTS branch label Dec 13, 2022
eddyashton added a commit to eddyashton/CCF that referenced this pull request Dec 13, 2022
@eddyashton
Remove unintended time checks from node-to-node validation (microsoft…
b3ee60c 
…#4733)

(cherry picked from commit 1ebcd07)

# Conflicts:
#	CHANGELOG.md
#	src/kv/test/kv_snapshot.cpp
@eddyashton eddyashton mentioned this pull request Dec 13, 2022
Merged
eddyashton added a commit to eddyashton/CCF that referenced this pull request Dec 13, 2022
@eddyashton
Remove unintended time checks from node-to-node validation (microsoft…
ee234e6 
…#4733)

(cherry picked from commit 1ebcd07)

# Conflicts:
#	CHANGELOG.md
eddyashton added a commit that referenced this pull request Dec 13, 2022
@eddyashton
[release/3.x] Cherry pick: Remove unintended time checks from node-to…
2867d3f 
…-node validation (#4733) (#4740)
eddyashton added a commit that referenced this pull request Dec 13, 2022
@eddyashton
[release/2.x] Cherry pick: Remove unintended time checks from node-to…
83bca7e 
…-node validation (#4733) (#4739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
2.x-todo PRs which should be backported to 2.x 3.x-todo PRs which should be backported to 3.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyashton @achamayou