Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running SNP pipeline against PR manually #4808

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

DomAyre
Copy link
Contributor

@DomAyre DomAyre commented Jan 9, 2023

When running the SNP pipeline manually for a PR, the PR id field isn't populated so the pipeline treats it like a run on a non-pr branch, meaning it gets the latest SHA from the merge branch rather than from the merge commit message as expected.

Fix is to look for the merge branch instead

@DomAyre DomAyre requested a review from a team January 9, 2023 10:35
@ghost
Copy link

ghost commented Jan 9, 2023

snp-pipeline-fix@59944 aka 20230109.10 vs main ewma over 20 builds from 59413 to 59913

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
59413 20221229.1 0.804632 17107.7 45682.8 6319.56 8.24484e+07 15454.3 1.50774e+07 47000.2 15626.1 8.78598e+06 13323.8 14122.4 4584.59 3640.43 5847.8 6.68883e+06 3482.94 5813.09 1.50774e+07 1561.62 7.73741e+06 24953.7 1283.06 7.21312e+06 1310 6.95098e+06 841159 1.17652e+06 8.08135e+06 3.11663e+07
59431 20221230.3 0.788723 17208.1 45920.9 6327.49 8.19242e+07 15413.6 1.50774e+07 46720.3 15633.7 8.78598e+06 14190.1 12487.6 4659.78 3614.84 5850.4 6.68883e+06 3369.98 5868.21 1.45532e+07 1572.42 7.73741e+06 24732.4 1288.84 7.73741e+06 1295.77 6.95098e+06 835572 1.17673e+06 8.15595e+06 3.07074e+07
59447 20230102.3 0.799308 17240.6 43816.5 6247.36 8.24484e+07 15456.9 1.53396e+07 46963.2 15605.3 8.78598e+06 14115.7 14164.4 4551.14 3572.63 5841.3 6.95098e+06 3324.72 5891.02 1.50774e+07 1571.91 7.73741e+06 24371.1 1285.66 7.21312e+06 1299.46 6.95098e+06 840360 1.18528e+06 8.1631e+06 3.14728e+07
59462 20230103.3 0.769441 17250.5 45839 6288.77 8.19242e+07 15421.1 1.53396e+07 46662.2 15639.7 9.31027e+06 14009.1 12279.4 4646.76 3620.99 5847.6 6.68883e+06 3331.48 5822.32 1.50774e+07 1572.01 7.73741e+06 27990.6 1285.98 7.21312e+06 1295.7 6.95098e+06 837562 1.17137e+06 8.17082e+06 3.07475e+07
59477 20230103.8 0.778442 17245.4 42006.4 6320.25 8.21863e+07 15465.8 1.50774e+07 46784.3 15598.2 9.31027e+06 13230.7 12362.6 4383.37 3684.3 5817.1 6.68883e+06 3305.68 5828.86 1.50774e+07 1568.13 7.73741e+06 27481.2 1282.18 7.47526e+06 1296.68 6.95098e+06 840264 1.17885e+06 8.15355e+06 3.07933e+07
59503 20230103.14 0.807001 17176.2 41838.3 6322.06 8.24484e+07 15654.4 1.53396e+07 46279.6 15621.7 9.31027e+06 13081.9 12221.1 4529.19 3530.7 5928.6 6.68883e+06 3399.76 5844.27 1.50774e+07 1571.32 7.73741e+06 22258.1 1293.52 7.47526e+06 1297.74 6.95098e+06 835260 1.17714e+06 8.17151e+06 3.01989e+07
59552 20230103.25 0.793474 17049.5 43539.9 6274.88 8.1662e+07 15453 1.50774e+07 45301.4 15583.5 8.52384e+06 13366.6 12521.6 4665.5 3550.42 5845.5 6.68883e+06 3420.06 5841.39 1.50774e+07 1570.79 7.73741e+06 24220.9 1288.84 7.73741e+06 1300.04 6.95098e+06 838063 1.17793e+06 8.04055e+06 3.07351e+07
59578 20230103.30 0.787714 16790.8 45826.5 6317.76 8.21863e+07 15729.5 1.53396e+07 45660 15625.5 9.31027e+06 13368.6 12472.2 4653.88 3659.56 5808.9 6.68883e+06 3324.89 5816.03 1.50774e+07 1573.11 7.73741e+06 23206.6 1289.07 7.21312e+06 1301.95 6.95098e+06 843043 1.18213e+06 8.15092e+06 3.08243e+07
59588 20230104.3 0.791543 17095 45701.8 6282.06 8.1662e+07 15431.4 1.50774e+07 47455.6 15613.9 8.78598e+06 13374.6 12556.1 4670.34 3701.22 5853.7 6.68883e+06 3325.31 5852 1.48153e+07 1571.33 7.73741e+06 24152.6 1283.97 7.73741e+06 1296.71 6.95098e+06 831776 1.18216e+06 8.17317e+06 3.16059e+07
59639 20230104.19 0.793442 17099 43700.9 6317.48 8.19242e+07 15711.9 1.53396e+07 47658.5 15654 8.78598e+06 13311.4 12386.3 4631.54 3538.75 5888.9 6.95098e+06 3445.45 5834.29 1.50774e+07 1565.38 7.73741e+06 27936.5 1289.07 7.73741e+06 1297.73 6.95098e+06 825987 1.18309e+06 8.15566e+06 3.10906e+07
59665 20230105.2 0.79042 17170.6 43827.9 6325.77 8.21863e+07 15559.4 1.53396e+07 47798.4 15682.3 8.78598e+06 13342.3 14174.5 4513.65 3622.04 5861.5 6.68883e+06 3476.38 5834.47 1.50774e+07 1570.57 7.73741e+06 22620.3 1284.7 7.73741e+06 1315.74 6.95098e+06 837979 1.17992e+06 8.17323e+06 3.07162e+07
59678 20230105.6 0.79786 17180.4 43679.2 6287.89 8.24484e+07 15447.8 1.53396e+07 44918.6 15613.9 8.78598e+06 13323.5 12415.2 4590.03 3582.73 5818 6.68883e+06 3448.03 5834.47 1.50774e+07 1571.65 7.73741e+06 27185.3 1284.57 7.73741e+06 1300.41 6.95098e+06 818802 1.15908e+06 8.14269e+06 3.08531e+07
59719 20230105.16 0.816841 17292 43799.1 6305.07 8.24484e+07 15717.1 1.53396e+07 47855.8 15978.5 8.2617e+06 13712.7 12652 4681.08 3583.49 5810.9 4.59168e+06 3465.9 5800.21 1.50774e+07 1572.4 7.73741e+06 23815.7 1293.32 7.47526e+06 1309.53 6.95098e+06 832333 1.17719e+06 8.15582e+06 3.13903e+07
59747 20230105.22 0.794968 17255.8 43731.7 6282.56 8.21863e+07 15541.7 1.50774e+07 48926.1 15864.1 8.2617e+06 12965.6 12297.4 4606.8 3539.16 5731.4 4.59168e+06 3455.56 5853.15 1.4291e+07 1568 7.73741e+06 27253 1270.88 7.47526e+06 1290.39 6.95098e+06 830778 1.17671e+06 8.15459e+06 3.08021e+07
59781 20230106.3 0.766149 17131.4 45865.6 6304.56 8.21863e+07 15485.8 1.53396e+07 47560.6 15996.4 8.2617e+06 13760.5 12520 4556.31 3545.8 5767.3 4.59168e+06 3482.61 5836.68 1.50774e+07 1571.69 7.73741e+06 29148.2 1285.69 7.21312e+06 1301.23 6.95098e+06 830718 1.18073e+06 8.13347e+06 3.12057e+07
59796 20230106.7 0.761166 17319.1 43805.5 6393.56 8.19242e+07 15526.1 1.50774e+07 49223.5 15994 8.2617e+06 13222.1 14194.6 4558.98 3539.1 5776.3 4.59168e+06 3405.32 5856.54 1.50774e+07 1573.51 7.73741e+06 22169.4 1295.62 7.47526e+06 1310.43 6.95098e+06 838036 1.17707e+06 8.15342e+06 3.07106e+07
59857 20230106.21 0.824187 17277.1 43619.5 5669.72 8.32349e+07 15450.5 1.53396e+07 49466.7 15764.6 8.2617e+06 13908.8 12589.5 4670.24 3547.54 5734.8 4.59168e+06 3478.18 5829.53 1.45532e+07 1556.45 7.73741e+06 22136.6 1288.43 7.47526e+06 1286.07 6.95098e+06 834573 1.18175e+06 8.14777e+06 3.08434e+07
59868 20230106.24 0.790629 17180.8 45688.2 6320.95 8.19242e+07 15386.8 1.50774e+07 47530.3 15929.1 8.2617e+06 13969.6 12598.1 4494.25 3549.42 5683.6 4.32954e+06 3319.78 5817.54 1.50774e+07 1574.04 7.73741e+06 24101.1 1284.61 7.21312e+06 1300.25 6.95098e+06 838278 1.18118e+06 8.13463e+06 3.16206e+07
59884 20230106.28 0.795828 17323.4 43547.6 6286.33 8.24484e+07 15226.6 1.50774e+07 49261.4 15824.1 8.2617e+06 13946.8 12335 4496.59 3644.43 5691.5 4.59168e+06 3497.16 5567.66 1.48153e+07 1549.25 7.73741e+06 27214.7 1274.97 7.47526e+06 1294.91 6.95098e+06 833582 1.17879e+06 8.15352e+06 3.14975e+07
59913 20230109.3 0.801341 17030.4 43745.9 6306.03 8.19242e+07 15416.5 1.50774e+07 49415.6 15958.3 8.2617e+06 13103.9 12604.9 4577.92 3575.21 5774.8 4.59168e+06 3419.69 5792.56 1.48153e+07 1576.66 7.73741e+06 22710.6 1284.27 7.21312e+06 1294.81 6.95098e+06 831861 1.17817e+06 8.13638e+06 3.10176e+07

snp-pipeline-fix

build_id build_number Commit latency factor tpcc_virtual_cft^ ls_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
59944 20230109.10 0.791129 17291.2 43766.5 6320.69 8.24484e+07 46643.3 12569 13092.6 4616.88 15464.1 1.53396e+07 3554.75 15979.2 8.2617e+06 5833.17 1.50774e+07 3345.95 5752 4.59168e+06 1570.48 7.73741e+06 29008.9 1282.38 7.21312e+06 1299.72 6.95098e+06 837195 1.17916e+06 8.15017e+06 3.08406e+07

images

@DomAyre DomAyre merged commit 68a4b38 into microsoft:main Jan 9, 2023
@DomAyre DomAyre deleted the snp-pipeline-fix branch January 9, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants