-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase tick intervals on SAN builds #5169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tick_every_10ms@68266 aka 20230412.28 vs main ewma over 20 builds from 67823 to 68193 Click to see tablemain
tick_every_10ms
|
jumaffre
changed the title
Draft: Tick enclave every 10ms in e2e tests
Increase tick intervals on SAN builds
Apr 12, 2023
achamayou
approved these changes
Apr 12, 2023
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jumaffre
added a commit
to achamayou/CCF
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5151 triggered a new edge case in the
Virtual Instrumented
pipeline where a node under load may struggle to cope with more work (e.g. large historical query). Based on my experiments, this is due to the aggressive tick interval on e2e tests (1ms
, less than the production default of10ms
to make test runs faster) as ticks are slower to process in the instrumented builds (100 ticks may take 30ms to be processed by the enclave). To fix this, this PR bumps the tick interval to10ms
for all instrumented builds.