Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tick intervals on SAN builds #5169

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Apr 12, 2023

#5151 triggered a new edge case in the Virtual Instrumented pipeline where a node under load may struggle to cope with more work (e.g. large historical query). Based on my experiments, this is due to the aggressive tick interval on e2e tests (1ms, less than the production default of 10ms to make test runs faster) as ticks are slower to process in the instrumented builds (100 ticks may take 30ms to be processed by the enclave). To fix this, this PR bumps the tick interval to 10ms for all instrumented builds.

@ghost
Copy link

ghost commented Apr 12, 2023

tick_every_10ms@68266 aka 20230412.28 vs main ewma over 20 builds from 67823 to 68193

Click to see table

main

build_id build_number Commit latency factor tpcc_virtual_cft^ tpcc_sgx_cft^ tpcc_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_full_js_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
67823 20230330.27 0.795251 17392.7 5683.84 8.32349e+07 45790.3 48747.9 12885 11546.3 4433.76 15419.7 1.50774e+07 3710.12 16051.7 7.99955e+06 5544.25 1.45532e+07 3230.92 5627.1 4.06739e+06 1487.93 7.99955e+06 46624.1 1308.03 7.73741e+06 1234.32 6.95098e+06 821759 1.18336e+06 8.15244e+06 3.08759e+07
67833 20230331.2 0.782741 17368.7 6325.56 8.21863e+07 46066.7 47210.1 12709.4 13212.3 4454.98 15875.6 1.50774e+07 3695.2 16129.9 7.99955e+06 5576.72 1.45532e+07 3370.45 5672.7 4.06739e+06 1506.74 7.73741e+06 48066.4 1315.52 7.47526e+06 1237.04 6.95098e+06 835702 1.17769e+06 8.17001e+06 3.08606e+07
67857 20230331.11 0.792167 17145.8 6259.04 8.24484e+07 43833.5 47918.6 12816.1 13109.9 4415.61 15347.5 1.53396e+07 3685.75 16080.8 7.99955e+06 5519.23 1.48153e+07 3256.48 5631.5 4.06739e+06 1488.37 7.73741e+06 45640.2 1304.95 7.21312e+06 1217.66 6.95098e+06 826906 1.17855e+06 8.15488e+06 3.09745e+07
67881 20230331.19 0.830533 17116.9 5655.64 8.27106e+07 45754.4 48395.9 12650.5 12917.4 4282.18 15251.8 1.50774e+07 3616.46 14468.8 7.99955e+06 5498.33 1.45532e+07 3246.53 5637.4 4.32954e+06 1482.67 7.73741e+06 45109.4 1306.87 8.2617e+06 1216.4 6.95098e+06 827013 1.18144e+06 8.15488e+06 3.08792e+07
67927 20230331.35 0.790044 17080.6 6272.5 8.21863e+07 45820.9 48066.5 12282.9 13103.6 4432.63 15812.1 1.50774e+07 3718.72 16080.8 7.99955e+06 5504.78 1.45532e+07 3244.81 5673.1 4.06739e+06 1505.52 7.73741e+06 41160.6 1301.13 7.21312e+06 1233.32 6.95098e+06 838072 1.18006e+06 8.15468e+06 3.17909e+07
67939 20230403.1 0.809918 17122 6261.48 8.19242e+07 43731.2 46617.6 12633.4 12614.8 4276.01 15813.3 1.50774e+07 3603.32 16140.7 7.99955e+06 5520.78 1.48153e+07 3157.1 5673.4 4.06739e+06 1511 7.73741e+06 46172.5 1316.03 7.21312e+06 1233.49 6.95098e+06 841945 1.18015e+06 8.154e+06 3.08132e+07
67949 20230403.6 0.80591 17116 6283.2 8.19242e+07 45597 48353.3 12489.6 12993.1 4437 15832.2 1.50774e+07 3741.8 16135.8 7.99955e+06 5517.83 1.48153e+07 3251.31 5568.5 4.06739e+06 1504.36 7.73741e+06 46495.7 1320.16 7.73741e+06 1233.86 6.95098e+06 832964 1.18046e+06 8.1492e+06 3.11701e+07
67961 20230403.9 0.841555 17023.7 6229.82 8.27106e+07 43684.2 48097.3 12412.7 13235.2 4328.23 15755.9 1.53396e+07 3724.04 16115.4 7.99955e+06 5491.79 1.48153e+07 3251.74 5663.6 4.06739e+06 1507.47 7.99955e+06 48185.3 1315.77 7.21312e+06 1233.41 6.95098e+06 825446 1.1791e+06 8.17522e+06 3.03939e+07
67974 20230403.12 0.80774 17365.7 6287.52 8.19242e+07 43716.7 47291.4 12382.5 13970 4415.41 15847.2 1.50774e+07 3698.72 16157.3 7.99955e+06 5517.65 1.50774e+07 3212.61 5671.7 4.06739e+06 1508.84 7.73741e+06 49028.1 1327.11 7.21312e+06 1239.56 6.95098e+06 836322 1.18107e+06 8.15524e+06 3.08072e+07
67988 20230404.1 0.778699 17079.5 6349.23 8.19242e+07 45642.8 48746.9 12788.8 13260.7 4420.7 15865.2 1.50774e+07 3708.7 16190.5 7.99955e+06 5540.54 1.45532e+07 3245.07 5704.1 4.06739e+06 1511.56 7.47526e+06 46058.9 1314.59 7.21312e+06 1238.48 6.95098e+06 837343 1.17887e+06 8.15384e+06 3.08927e+07
68022 20230405.3 0.787084 17638.2 6258.79 8.21863e+07 43711.1 47899.6 12831.6 13245.9 4244.17 15819.6 1.53396e+07 3616.09 16216.1 7.99955e+06 5531.72 1.45532e+07 3241.58 5712.7 4.06739e+06 1509.76 7.73741e+06 47667.7 1318.43 7.21312e+06 1235.51 6.95098e+06 824171 1.18291e+06 8.15381e+06 3.12734e+07
68024 20230405.4 0.80009 17366.8 6243.57 8.19242e+07 43560 47048.4 12364.6 12693.4 4274.02 15766.1 1.53396e+07 3602.37 16120.8 7.99955e+06 5474.31 1.50774e+07 3248.1 5656.8 4.06739e+06 1509.79 7.73741e+06 46186.9 1318.93 7.21312e+06 1228.64 6.95098e+06 834114 1.18016e+06 8.15527e+06 3.14024e+07
68059 20230406.2 0.778174 17084 6271.5 8.21863e+07 43477.4 46811.2 12445.8 13084.7 4267.35 15777.4 1.53396e+07 3598.92 16178.9 7.99955e+06 5539.82 1.45532e+07 3311.24 5674.1 4.06739e+06 1512.16 7.73741e+06 48769.1 1318.76 7.21312e+06 1234.77 6.95098e+06 828391 1.18458e+06 8.04282e+06 3.06408e+07
68096 20230406.13 0.788694 17326.2 5649.47 8.32349e+07 43942.1 47946.9 12291.7 13612.7 4245.18 15472.3 1.50774e+07 3711.99 15971.1 7.99955e+06 5496.97 1.45532e+07 3237.63 5673.6 4.06739e+06 1485.38 7.99955e+06 44437 1300.39 8.2617e+06 1218.26 6.95098e+06 825479 1.17994e+06 8.1469e+06 3.08643e+07
68112 20230407.2 0.784271 17094.3 6301.2 8.13999e+07 43722.3 47240.4 12508.7 12947.1 4440.87 15864 1.53396e+07 3715.24 16136.5 7.99955e+06 5529.77 1.48153e+07 3369.16 5675.1 4.06739e+06 1506.24 7.73741e+06 47045.1 1323.36 7.21312e+06 1231.91 6.95098e+06 834199 1.18096e+06 8.14564e+06 3.0649e+07
68121 20230410.1 0.807321 17016.7 6305.14 8.19242e+07 45837.9 47157.2 12731.6 13880.8 4269.66 15836.5 1.53396e+07 3617.89 16196.6 7.99955e+06 5556.05 1.45532e+07 3230.52 5612 4.06739e+06 1508.48 7.73741e+06 46472.2 1317.23 7.21312e+06 1239.01 6.95098e+06 837941 1.17859e+06 8.15628e+06 3.05476e+07
68137 20230411.2 0.800513 17656.2 6306.72 8.21863e+07 45609.6 40123.1 12882.1 12730.7 4471.23 15896.3 1.50774e+07 3701 16120.3 7.99955e+06 5523.83 1.48153e+07 3244.09 5664.4 4.06739e+06 1512.35 7.73741e+06 46090.3 1323.03 7.73741e+06 1236.15 6.68883e+06 838908 1.17562e+06 8.15199e+06 3.07854e+07
68151 20230411.7 0.76272 17323.8 6276.77 8.21863e+07 45798 47077.7 12408 13631.8 4414.32 15883.8 1.53396e+07 3718.39 16166.6 7.99955e+06 5559.18 1.45532e+07 3224.92 5703.5 4.06739e+06 1512.63 7.73741e+06 44941.6 1320.61 7.21312e+06 1235.68 6.95098e+06 832029 1.17578e+06 8.14029e+06 3.1781e+07
68159 20230412.1 0.807709 17021 6292.53 8.24484e+07 43706 48086.2 12359.1 13928.9 4270.39 15802.3 1.56017e+07 3748.95 16174.5 7.99955e+06 5495.72 1.4291e+07 3245.44 5673.6 4.06739e+06 1513.72 7.73741e+06 45182.8 1317.74 7.21312e+06 1240.45 6.68883e+06 826769 1.17839e+06 8.15524e+06 3.07683e+07
68193 20230412.10 0.774075 17207.1 6266.3 8.21863e+07 43482 47369.6 12449.4 13752.5 4247.31 15799.2 1.50774e+07 3738.91 16050.4 7.99955e+06 5474.2 1.45532e+07 3211.94 5668.6 4.06739e+06 1503.26 7.73741e+06 46751 1314.82 7.73741e+06 1230.66 6.95098e+06 833140 1.1776e+06 8.14661e+06 3.10628e+07

tick_every_10ms

build_id build_number Commit latency factor tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_virtual_cft^ ls_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_js_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem hist_sgx_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
68237 20230412.20 1.53697 6326.24 8.3497e+07 17278.1 46037.7 15992.8 1.6126e+07 47771.2 16319.3 9.83456e+06 12921.5 13959.8 5528.38 1.56017e+07 5835.1 4.59168e+06 4350.94 3680.79 1523.88 7.99955e+06 3302.45 1338.87 8.2617e+06 37785.8 1243.08 7.47526e+06 835702 1.17681e+06 8.16535e+06 3.13399e+07
68252 20230412.24 0.784621 6330.26 8.24484e+07 17078.9 43562.2 15874.2 1.50774e+07 41072.5 16186.3 7.99955e+06 12270.7 13526.3 5521.72 1.45532e+07 5706.9 4.06739e+06 4270.23 3754.68 1521.37 7.73741e+06 3242.41 1320.17 7.73741e+06 46550.7 1248.66 6.95098e+06 828589 1.18082e+06 8.16795e+06 3.08007e+07
68266 20230412.28 0.806395 6279.51 8.21863e+07 16805.3 43599.7 15766.2 1.53396e+07 47362.4 16145.5 7.99955e+06 12582.8 12723.1 5539.24 1.45532e+07 5704.2 4.06739e+06 4273.77 3637.07 1514.86 7.73741e+06 3126.77 1324.64 7.99955e+06 46277.9 1238.62 6.95098e+06 837311 1.18119e+06 8.17226e+06 3.0748e+07

images

@jumaffre jumaffre changed the title Draft: Tick enclave every 10ms in e2e tests Increase tick intervals on SAN builds Apr 12, 2023
Julien Maffre added 2 commits April 12, 2023 15:30
@achamayou achamayou marked this pull request as ready for review April 12, 2023 19:05
@achamayou achamayou requested a review from a team April 12, 2023 19:05
@achamayou
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@achamayou achamayou merged commit d16752f into microsoft:main Apr 12, 2023
jumaffre added a commit to achamayou/CCF that referenced this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants