-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNP: add support to read UVM security context from files rather than environment #5175
Merged
jumaffre
merged 36 commits into
microsoft:main
from
jumaffre:snp_endorsements_from_files
Apr 21, 2023
Merged
SNP: add support to read UVM security context from files rather than environment #5175
jumaffre
merged 36 commits into
microsoft:main
from
jumaffre:snp_endorsements_from_files
Apr 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
reviewed
Apr 13, 2023
snp_endorsements_from_files@69145 aka 20230421.26 vs main ewma over 20 builds from 68677 to 69139 Click to see tablemain
snp_endorsements_from_files
|
… into snp_endorsements_from_files
… into snp_endorsements_from_files
… into snp_endorsements_from_files
achamayou
reviewed
Apr 20, 2023
achamayou
reviewed
Apr 20, 2023
achamayou
approved these changes
Apr 20, 2023
Marking this PR as draft as I want to make sure it still works in North Europe with the old way of setting the security context via envvars. |
… into snp_endorsements_from_files
… into snp_endorsements_from_files
/azp run |
Azure Pipelines successfully started running 5 pipeline(s). |
achamayou
approved these changes
Apr 21, 2023
This was referenced Apr 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5164
CCF nodes can now read the UVM security context from files as well as from environment variables, as per the recent changes made to confidential ACI.