-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout idle node-to-node channels #5266
Merged
achamayou
merged 9 commits into
microsoft:main
from
eddyashton:timeout_idle_n2n_channels
May 19, 2023
Merged
Timeout idle node-to-node channels #5266
achamayou
merged 9 commits into
microsoft:main
from
eddyashton:timeout_idle_n2n_channels
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eddyashton a good candidate for a canary poke? |
achamayou
approved these changes
May 16, 2023
timeout_idle_n2n_channels@70595 aka 20230519.10 vs main ewma over 20 builds from 70261 to 70589 Click to see tablemain
timeout_idle_n2n_channels
|
eddyashton
added
auto-backport
Automatically backport this PR to LTS branch
4.x-todo
PRs which should be backported to 4.x
labels
May 18, 2023
ghost
mentioned this pull request
May 19, 2023
ghost
pushed a commit
that referenced
this pull request
May 19, 2023
(cherry picked from commit 400818a)
achamayou
pushed a commit
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4.x-todo
PRs which should be backported to 4.x
auto-backport
Automatically backport this PR to LTS branch
backported
This PR was successfully backported to LTS branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2672.
I believe all of the groundwork to do this safely (decoupling host and enclave state for these channels, robustly recreating channels on-demand) has been done already, and all that was left (this PR) is adding idle time tracking? There's a non-zero risk of this introducing subtle new node-to-node failures, so I'll see what the CI thinks of a few runs.