Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getVersionOfPreviousWrite to TypeScript TypedKvMap #5451

Merged
merged 8 commits into from
Jul 14, 2023
Merged

Add getVersionOfPreviousWrite to TypeScript TypedKvMap #5451

merged 8 commits into from
Jul 14, 2023

Conversation

eddyashton
Copy link
Member

This function was exposed in JS, so callable, but not present on the TypeScript TypedKvMap. I've added it there, with associated test, and a bit of cleanup of the existing test.

@eddyashton eddyashton requested a review from a team July 13, 2023 09:40
@ghost
Copy link

ghost commented Jul 13, 2023 •
edited by ghost
Loading

getVersion_typedKvMap@73112 aka 20230714.7 vs main ewma over 20 builds from 72710 to 73098

Click to see table

main

build_id build_number Commit latency factor ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ hist_sgx_cft^ RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
72710 20230710.6 0.788794 20005.4 1.88908e+07 20269.5 1.25993e+07 22866.8 1.25993e+07 6728.18 1.67936e+07 6512.5 6.30784e+06 35431.5 2.30851e+07 1759.65 1.05021e+07 63117.5 45697.8 47934.7 55206.3 12422.3 12210.6 1445.95 1.05021e+07 4493.53 3483.33 1433.41 1.05021e+07 3305.55 47749.1 828889 1.18077e+06 8.1542e+06 3.122e+07
72744 20230710.14 0.800586 19954.9 1.88908e+07 20200.9 1.25993e+07 22878 1.25993e+07 6715.39 1.67936e+07 6521.4 6.30784e+06 35473.9 2.30851e+07 1743.27 1.05021e+07 57523.5 45532.2 47676.7 55193.2 12589.1 12995.6 1452.47 1.05021e+07 4534.16 3421.51 1431.64 1.05021e+07 3301.99 48992.4 834304 1.17933e+06 8.11619e+06 3.06853e+07
72798 20230710.26 0.812772 19893.6 1.88908e+07 20164.3 1.05021e+07 22812.5 1.25993e+07 6324.2 1.67936e+07 6427.2 6.30784e+06 35632.9 2.51822e+07 1739 1.05021e+07 56675 45615.6 47320.7 55111.1 12475.3 12598 1435.26 1.05021e+07 4518.38 3573.76 1427.5 1.05021e+07 3304.65 47752.2 834517 1.17285e+06 8.13706e+06 3.13562e+07
72814 20230711.1 0.822951 20061.4 1.88908e+07 20238.1 1.25993e+07 22988 1.25993e+07 6721.4 1.67936e+07 6564.4 6.30784e+06 35372.8 2.51822e+07 1745.99 1.05021e+07 61833.3 45650.5 47315.6 55255 12539.8 12841.6 1438.48 1.05021e+07 4455.94 3537.7 1424.39 1.05021e+07 3292.8 46633.5 838546 1.1806e+06 8.15394e+06 3.07757e+07
72829 20230711.7 0.791713 19901.7 1.88908e+07 20225 1.25993e+07 22820.9 1.25993e+07 6678.88 1.67936e+07 6560.5 6.30784e+06 34466.6 2.30851e+07 1748.32 1.05021e+07 56906 45915.2 47081 54845.7 12541.4 12672.2 1439.48 1.05021e+07 4509.76 3554.71 1431.08 1.05021e+07 3323.41 48662.1 824913 1.17963e+06 8.13434e+06 3.0945e+07
72849 20230711.11 0.812991 19765.2 1.88908e+07 20171.1 1.25993e+07 22899.3 1.25993e+07 6314.4 1.67936e+07 6474 6.30784e+06 35982.6 2.30851e+07 1739.82 1.05021e+07 58794.4 45717.3 47912.9 54851.1 12423.3 12836.8 1436.66 1.05021e+07 4462.62 3432.06 1431.05 1.05021e+07 3293.33 46454.3 838987 1.17507e+06 8.15345e+06 3.10148e+07
72854 20230711.13 0.807603 19837 1.88908e+07 20099.6 1.25993e+07 22889.3 1.25993e+07 6707.87 1.67936e+07 6528 6.30784e+06 35512.6 2.51822e+07 1734.98 1.05021e+07 70109.4 46040.2 47781 55305.6 12411.2 12938.3 1433.09 1.05021e+07 4412.3 3532.04 1428.14 1.05021e+07 3273.64 43626.8 832428 1.17996e+06 8.15352e+06 3.07563e+07
72870 20230711.17 0.800785 19955.2 1.88908e+07 20222.9 1.25993e+07 22924.8 1.25993e+07 6725.15 1.67936e+07 6524 6.30784e+06 35619.8 2.51822e+07 1741.44 1.05021e+07 59075.4 43528.1 47370 55203 12448.6 12865.2 1437.05 1.05021e+07 4534.37 3442.38 1429.98 1.05021e+07 3281.94 48492.2 834837 1.18e+06 8.15209e+06 3.13826e+07
72899 20230712.1 0.817629 20098 1.88908e+07 20256.9 1.25993e+07 22921.3 1.25993e+07 6721.85 1.67936e+07 6584.3 6.30784e+06 35539.2 2.51822e+07 1745.58 1.05021e+07 61732.8 46005.4 46267.2 54817.6 12361 12878 1442.14 1.05021e+07 4513.9 3525.42 1430.43 1.05021e+07 3277.82 50523.7 833552 1.18361e+06 8.1731e+06 3.07896e+07
72916 20230712.9 0.797894 19992.6 1.88908e+07 20209.5 1.25993e+07 22903 1.25993e+07 6686.76 1.67936e+07 6519.5 6.30784e+06 35694.8 2.51822e+07 1736.56 1.05021e+07 64831.7 46029.2 47114.3 55431.5 12397.4 12809.2 1439.82 1.05021e+07 4414.02 3533.23 1428.56 1.05021e+07 3276.07 45948 830755 1.18136e+06 8.08135e+06 3.08918e+07
72928 20230712.13 0.799723 20046.2 1.67936e+07 20161.4 1.25993e+07 23021.4 1.25993e+07 6710.58 1.67936e+07 6564.9 6.30784e+06 35535.6 2.51822e+07 1767.93 1.05021e+07 61495.9 45762.6 46880.5 55048.8 12558.5 12672.7 1445.06 1.05021e+07 4453.04 3523.86 1436 1.05021e+07 3283.39 44788.5 840580 1.18275e+06 8.15465e+06 3.08862e+07
72981 20230712.26 0.813809 19966.3 1.88908e+07 20119.8 1.25993e+07 22909.6 1.25993e+07 6379.89 1.67936e+07 6516.4 6.30784e+06 35275.6 2.51822e+07 1747.26 1.05021e+07 65880.8 45598.2 44233.5 54556.6 12513.5 12865.7 1443.44 1.05021e+07 4495.36 3520 1432.78 1.05021e+07 3275.66 48089.6 840750 1.17558e+06 8.15374e+06 3.10944e+07
72986 20230712.27 0.812176 19693.3 1.88908e+07 19960 1.25993e+07 22888.3 1.25993e+07 6335.98 1.67936e+07 6467.1 6.30784e+06 35645.6 2.51822e+07 1742.45 1.05021e+07 56481.4 45590.3 47008.4 54528.8 12483.4 12724.4 1438.04 1.05021e+07 4350.1 3379.21 1405.44 1.05021e+07 3283.36 50037.2 834873 1.17802e+06 8.14599e+06 3.09174e+07
73004 20230712.33 0.812968 19911.9 1.88908e+07 20179.4 1.25993e+07 22792.5 1.25993e+07 6707.62 1.67936e+07 6563.5 6.30784e+06 35930.1 2.51822e+07 1750.57 1.05021e+07 62858.9 43847.4 46156.8 54946.3 12457.4 12783.8 1438.9 1.05021e+07 4408.68 3491.91 1436.09 1.05021e+07 3301.96 47692.9 829483 1.17554e+06 8.14939e+06 3.07674e+07
73023 20230712.38 0.776197 19803.6 1.88908e+07 20142.2 1.25993e+07 22794.7 1.25993e+07 6378.49 1.67936e+07 6475.7 6.30784e+06 35346.2 2.51822e+07 1739.62 1.05021e+07 63921.5 43776.5 46663.1 55196.6 12275.1 12853.7 1437.25 1.05021e+07 4545.13 3535.92 1425.26 1.05021e+07 3295.26 47073.2 842747 1.1838e+06 8.15358e+06 3.13394e+07
73033 20230713.1 0.85485 19966.7 1.88908e+07 20161.4 1.25993e+07 22890.6 1.25993e+07 6446.22 1.67936e+07 6478.2 6.30784e+06 35459.9 2.51822e+07 1741.88 1.05021e+07 65726.9 45771 47061.7 56071.3 12590.7 12839.3 1441.24 1.05021e+07 4508.37 3557.15 1426.37 1.05021e+07 3303.04 48582 818389 1.18097e+06 8.153e+06 3.073e+07
73052 20230713.8 0.802062 19736 1.88908e+07 20080.7 1.25993e+07 22670.8 1.25993e+07 6366.89 1.67936e+07 6497.5 6.30784e+06 35363.7 2.51822e+07 1752.97 1.05021e+07 70372.8 45795.1 47174.7 55397.1 12396.3 12835.5 1433.62 1.05021e+07 4474.16 3550.68 1435.81 1.05021e+07 3257.04 47685.4 822746 1.17828e+06 8.15413e+06 3.03948e+07
73066 20230713.13 0.795208 19952.2 1.88908e+07 20043.5 1.25993e+07 22849.1 1.25993e+07 6673.85 1.67936e+07 6469.8 6.30784e+06 35726.5 2.30851e+07 1739.9 1.05021e+07 68936.8 45653.8 47465.1 55269.1 12490.2 12819.2 1436.77 1.05021e+07 4546.34 3555.72 1429.29 1.05021e+07 3310.87 43220.4 833479 1.17929e+06 8.15378e+06 3.10439e+07
73091 20230713.22 0.793568 19794.1 1.88908e+07 20195.1 1.25993e+07 22861.7 1.25993e+07 6681.43 1.67936e+07 6508 6.30784e+06 35187.3 2.51822e+07 1746.01 1.05021e+07 63682.1 46198.4 47551.3 55228 12584.9 12689.9 1442.07 1.05021e+07 4479.41 3544.88 1430.15 1.05021e+07 3271.82 44792.2 837043 1.17886e+06 8.15332e+06 3.07771e+07
73098 20230714.1 0.790865 19988.6 1.88908e+07 20230 1.25993e+07 22972.5 1.25993e+07 6374.19 1.67936e+07 6511.7 6.30784e+06 35632.3 2.51822e+07 1745.51 1.05021e+07 64627 45877.5 47559.3 54965.2 12609.9 12662.7 1432.05 1.05021e+07 4538.04 3556.02 1425.52 1.05021e+07 3275.15 48445.8 843704 1.18342e+06 8.15209e+06 3.16739e+07

getVersion_typedKvMap

build_id build_number Commit latency factor pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_mt_virtual_cft^ pi_ls_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
73051 20230713.7 0.784858 35439.8 2.51822e+07 43599.1 46851.6 55648.7 19997.6 1.88908e+07 12342.6 20191 1.25993e+07 58785.7 12860.8 22891.8 1.25993e+07 4314.54 6338.24 1.67936e+07 6484.1 6.30784e+06 3457.9 3295.72 1741.39 1.05021e+07 44361 1439.88 1.05021e+07 1431.15 1.05021e+07 831504 1.17879e+06 8.15089e+06 3.08109e+07
73063 20230713.11 0.78243 35074.3 2.51822e+07 43640.6 46349.3 55042.8 19754.4 1.88908e+07 12396.2 20107.5 1.25993e+07 67559.9 12893.3 22825.8 1.25993e+07 4506.05 6388.96 1.67936e+07 6503.9 6.30784e+06 3529.53 3238.45 1742.46 1.05021e+07 47622.5 1439.78 1.05021e+07 1431.03 1.05021e+07 836695 1.17367e+06 8.15131e+06 3.06826e+07
73072 20230713.14 0.788153 35541.5 2.30851e+07 45674 46951.9 55182.1 19773.1 1.88908e+07 12475.7 20064.2 1.25993e+07 62950.5 12832.5 22807.8 1.25993e+07 4520.82 6315.44 1.67936e+07 6485.85 6.30784e+06 3545.33 3285.05 1745.93 1.05021e+07 39599.4 1440.58 1.05021e+07 1425.36 1.05021e+07 831419 1.18707e+06 8.13528e+06 3.14269e+07
73112 20230714.7 0.783288 35506.9 2.51822e+07 45737.1 47514.3 55324.5 20019.4 1.88908e+07 12536.6 20205.4 1.25993e+07 56976.2 12783.3 22960.4 1.25993e+07 4428.07 6359.86 1.67936e+07 6561.1 6.30784e+06 3549.52 3304.2 1743.63 1.05021e+07 47892.5 1441.68 1.05021e+07 1432.9 1.05021e+07 831751 1.17739e+06 8.15602e+06 3.08397e+07

images

@eddyashton eddyashton added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Jul 14, 2023
@eddyashton eddyashton enabled auto-merge (squash) July 14, 2023 08:56
@eddyashton eddyashton merged commit 37ec459 into microsoft:main Jul 14, 2023
@ghost ghost mentioned this pull request Jul 14, 2023
Merged
ghost pushed a commit that referenced this pull request Jul 14, 2023
@eddyashton
Add getVersionOfPreviousWrite to TypeScript TypedKvMap (#5451)
a83b539 
(cherry picked from commit 37ec459)
@ghost ghost added the backported This PR was successfully backported to LTS branch label Jul 14, 2023
@ghost ghost mentioned this pull request Jul 14, 2023
Merged
eddyashton pushed a commit that referenced this pull request Jul 14, 2023
[release/4.x] Cherry pick: Add getVersionOfPreviousWrite to TypeScr…
176cf6a 
…ipt `TypedKvMap` (#5451) (#5455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyashton @achamayou