Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lts_compatibility in SGX Debug - don't pass unsafe --enclave-log-level #5461

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix lts_compatibility in SGX Debug - don't pass unsafe --enclave-log-level #5461

merged 1 commit into from
Jul 18, 2023

Conversation

eddyashton
Copy link
Member

#5375 introduced a crash in the lts_compatibility test in SGX Debug builds that was missed until 4.0.5 was cut. It attempts to pass --enclave-log-level Debug to LTS nodes built with minimum logging level = INFO, and those nodes throw at CLI validation.

This is a quick-fix to stop passing the argument at all when it is potentially unsafe. It does mean the infra won't produce the verbose logs for SGX Debug, but we can resolve that with a more targeted fix when we have more time.

@eddyashton eddyashton added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Jul 18, 2023
@eddyashton eddyashton requested a review from a team July 18, 2023 08:22
@eddyashton eddyashton mentioned this pull request Jul 18, 2023
Merged
6 tasks
@ghost
Copy link

ghost commented Jul 18, 2023

lts_no_sgx_debug_loglevel@73213 aka 20230718.6 vs main ewma over 20 builds from 72849 to 73203

Click to see table

main

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
72849 20230711.11 0.812991 58794.4 35982.6 2.30851e+07 45717.3 47912.9 54851.1 12423.3 12836.8 4462.62 3432.06 3293.33 46454.3 19765.2 1.88908e+07 20171.1 1.25993e+07 22899.3 1.25993e+07 6314.4 1.67936e+07 6474 6.30784e+06 1739.82 1.05021e+07 1436.66 1.05021e+07 1431.05 1.05021e+07 838987 1.17507e+06 8.15345e+06 3.10148e+07
72854 20230711.13 0.807603 70109.4 35512.6 2.51822e+07 46040.2 47781 55305.6 12411.2 12938.3 4412.3 3532.04 3273.64 43626.8 19837 1.88908e+07 20099.6 1.25993e+07 22889.3 1.25993e+07 6707.87 1.67936e+07 6528 6.30784e+06 1734.98 1.05021e+07 1433.09 1.05021e+07 1428.14 1.05021e+07 832428 1.17996e+06 8.15352e+06 3.07563e+07
72870 20230711.17 0.800785 59075.4 35619.8 2.51822e+07 43528.1 47370 55203 12448.6 12865.2 4534.37 3442.38 3281.94 48492.2 19955.2 1.88908e+07 20222.9 1.25993e+07 22924.8 1.25993e+07 6725.15 1.67936e+07 6524 6.30784e+06 1741.44 1.05021e+07 1437.05 1.05021e+07 1429.98 1.05021e+07 834837 1.18e+06 8.15209e+06 3.13826e+07
72899 20230712.1 0.817629 61732.8 35539.2 2.51822e+07 46005.4 46267.2 54817.6 12361 12878 4513.9 3525.42 3277.82 50523.7 20098 1.88908e+07 20256.9 1.25993e+07 22921.3 1.25993e+07 6721.85 1.67936e+07 6584.3 6.30784e+06 1745.58 1.05021e+07 1442.14 1.05021e+07 1430.43 1.05021e+07 833552 1.18361e+06 8.1731e+06 3.07896e+07
72916 20230712.9 0.797894 64831.7 35694.8 2.51822e+07 46029.2 47114.3 55431.5 12397.4 12809.2 4414.02 3533.23 3276.07 45948 19992.6 1.88908e+07 20209.5 1.25993e+07 22903 1.25993e+07 6686.76 1.67936e+07 6519.5 6.30784e+06 1736.56 1.05021e+07 1439.82 1.05021e+07 1428.56 1.05021e+07 830755 1.18136e+06 8.08135e+06 3.08918e+07
72928 20230712.13 0.799723 61495.9 35535.6 2.51822e+07 45762.6 46880.5 55048.8 12558.5 12672.7 4453.04 3523.86 3283.39 44788.5 20046.2 1.67936e+07 20161.4 1.25993e+07 23021.4 1.25993e+07 6710.58 1.67936e+07 6564.9 6.30784e+06 1767.93 1.05021e+07 1445.06 1.05021e+07 1436 1.05021e+07 840580 1.18275e+06 8.15465e+06 3.08862e+07
72981 20230712.26 0.813809 65880.8 35275.6 2.51822e+07 45598.2 44233.5 54556.6 12513.5 12865.7 4495.36 3520 3275.66 48089.6 19966.3 1.88908e+07 20119.8 1.25993e+07 22909.6 1.25993e+07 6379.89 1.67936e+07 6516.4 6.30784e+06 1747.26 1.05021e+07 1443.44 1.05021e+07 1432.78 1.05021e+07 840750 1.17558e+06 8.15374e+06 3.10944e+07
72986 20230712.27 0.812176 56481.4 35645.6 2.51822e+07 45590.3 47008.4 54528.8 12483.4 12724.4 4350.1 3379.21 3283.36 50037.2 19693.3 1.88908e+07 19960 1.25993e+07 22888.3 1.25993e+07 6335.98 1.67936e+07 6467.1 6.30784e+06 1742.45 1.05021e+07 1438.04 1.05021e+07 1405.44 1.05021e+07 834873 1.17802e+06 8.14599e+06 3.09174e+07
73004 20230712.33 0.812968 62858.9 35930.1 2.51822e+07 43847.4 46156.8 54946.3 12457.4 12783.8 4408.68 3491.91 3301.96 47692.9 19911.9 1.88908e+07 20179.4 1.25993e+07 22792.5 1.25993e+07 6707.62 1.67936e+07 6563.5 6.30784e+06 1750.57 1.05021e+07 1438.9 1.05021e+07 1436.09 1.05021e+07 829483 1.17554e+06 8.14939e+06 3.07674e+07
73023 20230712.38 0.776197 63921.5 35346.2 2.51822e+07 43776.5 46663.1 55196.6 12275.1 12853.7 4545.13 3535.92 3295.26 47073.2 19803.6 1.88908e+07 20142.2 1.25993e+07 22794.7 1.25993e+07 6378.49 1.67936e+07 6475.7 6.30784e+06 1739.62 1.05021e+07 1437.25 1.05021e+07 1425.26 1.05021e+07 842747 1.1838e+06 8.15358e+06 3.13394e+07
73033 20230713.1 0.85485 65726.9 35459.9 2.51822e+07 45771 47061.7 56071.3 12590.7 12839.3 4508.37 3557.15 3303.04 48582 19966.7 1.88908e+07 20161.4 1.25993e+07 22890.6 1.25993e+07 6446.22 1.67936e+07 6478.2 6.30784e+06 1741.88 1.05021e+07 1441.24 1.05021e+07 1426.37 1.05021e+07 818389 1.18097e+06 8.153e+06 3.073e+07
73052 20230713.8 0.802062 70372.8 35363.7 2.51822e+07 45795.1 47174.7 55397.1 12396.3 12835.5 4474.16 3550.68 3257.04 47685.4 19736 1.88908e+07 20080.7 1.25993e+07 22670.8 1.25993e+07 6366.89 1.67936e+07 6497.5 6.30784e+06 1752.97 1.05021e+07 1433.62 1.05021e+07 1435.81 1.05021e+07 822746 1.17828e+06 8.15413e+06 3.03948e+07
73066 20230713.13 0.795208 68936.8 35726.5 2.30851e+07 45653.8 47465.1 55269.1 12490.2 12819.2 4546.34 3555.72 3310.87 43220.4 19952.2 1.88908e+07 20043.5 1.25993e+07 22849.1 1.25993e+07 6673.85 1.67936e+07 6469.8 6.30784e+06 1739.9 1.05021e+07 1436.77 1.05021e+07 1429.29 1.05021e+07 833479 1.17929e+06 8.15378e+06 3.10439e+07
73091 20230713.22 0.793568 63682.1 35187.3 2.51822e+07 46198.4 47551.3 55228 12584.9 12689.9 4479.41 3544.88 3271.82 44792.2 19794.1 1.88908e+07 20195.1 1.25993e+07 22861.7 1.25993e+07 6681.43 1.67936e+07 6508 6.30784e+06 1746.01 1.05021e+07 1442.07 1.05021e+07 1430.15 1.05021e+07 837043 1.17886e+06 8.15332e+06 3.07771e+07
73098 20230714.1 0.790865 64627 35632.3 2.51822e+07 45877.5 47559.3 54965.2 12609.9 12662.7 4538.04 3556.02 3275.15 48445.8 19988.6 1.88908e+07 20230 1.25993e+07 22972.5 1.25993e+07 6374.19 1.67936e+07 6511.7 6.30784e+06 1745.51 1.05021e+07 1432.05 1.05021e+07 1425.52 1.05021e+07 843704 1.18342e+06 8.15209e+06 3.16739e+07
73119 20230714.10 0.819362 69624.9 36055.4 2.51822e+07 45837.8 47413.6 55492.5 12496 12661.6 4370.56 3530.65 3285.52 48956 20021.7 1.88908e+07 20101.8 1.25993e+07 22955.1 1.25993e+07 6359.6 1.67936e+07 6473.5 6.30784e+06 1736.18 1.05021e+07 1435.26 1.05021e+07 1421.37 1.05021e+07 830236 1.18254e+06 8.13234e+06 2.99709e+07
73140 20230714.16 0.775764 64726.9 35787.7 2.51822e+07 45939.2 47508.2 56422.4 12443.3 12725.2 4410.45 3556.53 3276.78 46529 19982.8 1.88908e+07 20136 1.25993e+07 23086 1.25993e+07 6702.03 1.67936e+07 6473.1 6.30784e+06 1740.25 1.05021e+07 1437.95 1.05021e+07 1428 1.05021e+07 834004 1.18232e+06 8.02426e+06 3.15227e+07
73180 20230717.1 0.800222 62847.2 35716.3 2.51822e+07 45834.3 46216.7 56263.1 12379.3 12902.1 4450.21 3464.92 3276.36 43251.5 19924.6 1.88908e+07 20159.7 1.25993e+07 22998.5 1.25993e+07 6718.37 1.67936e+07 6519.5 6.30784e+06 1745.61 1.05021e+07 1444.06 1.05021e+07 1434.21 1.05021e+07 835650 1.18058e+06 8.15572e+06 3.10261e+07
73193 20230717.7 0.78772 69751.7 36011.4 2.51822e+07 43736.8 46336 55360.9 12395.1 12427.6 4489.52 3540.58 3265.45 47368.6 19894.2 1.88908e+07 20159.3 1.25993e+07 22907.9 1.25993e+07 6307.23 1.67936e+07 6514.9 6.30784e+06 1744.85 1.05021e+07 1440.41 1.05021e+07 1422.28 1.05021e+07 838900 1.1819e+06 8.15066e+06 3.07097e+07
73203 20230718.1 0.793044 62165.1 35794.8 2.51822e+07 45920.6 42674.3 56150.9 12464.6 12757.4 4507.92 3532 3266.4 45151 19822.2 1.88908e+07 20161.2 1.25993e+07 22927.2 1.25993e+07 6704.73 1.67936e+07 6511.9 6.30784e+06 1746.77 1.05021e+07 1441.47 1.05021e+07 1435.35 1.05021e+07 832649 1.17671e+06 8.15647e+06 3.08346e+07

lts_no_sgx_debug_loglevel

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_js_virtual_cft^ ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
73213 20230718.6 0.78388 57046.2 43739.4 46864.7 56482.5 19778.2 1.88908e+07 12455.7 20032.4 1.25993e+07 12688.2 35835.6 2.51822e+07 22910.5 1.25993e+07 4494.46 6314.65 1.67936e+07 6427.8 6.30784e+06 3544.21 3288.44 1733.68 1.05021e+07 50540.1 1437.25 1.05021e+07 1426.2 1.05021e+07 832900 1.18708e+06 8.15167e+06 3.14269e+07

images

@achamayou achamayou merged commit bb5438f into microsoft:main Jul 18, 2023
ghost pushed a commit that referenced this pull request Jul 18, 2023
@eddyashton
Fix lts_compatibility in SGX Debug - don't pass unsafe `--enclave-l…
179f3c0 
…og-level` (#5461)

(cherry picked from commit bb5438f)
@ghost ghost mentioned this pull request Jul 18, 2023
Merged
@ghost ghost added the backported This PR was successfully backported to LTS branch label Jul 18, 2023
achamayou pushed a commit that referenced this pull request Jul 18, 2023
[release/4.x] Cherry pick: Fix lts_compatibility in SGX Debug - don…
62f572e 
…'t pass unsafe `--enclave-log-level` (#5461) (#5462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyashton @achamayou