Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose COSE identity content in JS/TS apps #5465

Merged
merged 14 commits into from
Jul 20, 2023
Merged

Expose COSE identity content in JS/TS apps #5465

merged 14 commits into from
Jul 20, 2023

Conversation

jumaffre
Copy link
Contributor

@jumaffre jumaffre commented Jul 18, 2023 •
edited
Loading

Resolves #5459

The COSE content is now exposed to JavaScript/TypeScript apps for user_cose_sign1 authenticated endpoints.

TODO:

  • New end-to-end test to test that these values are set correctly.

@ghost
Copy link

ghost commented Jul 18, 2023 •
edited by ghost
Loading

expose_cose_content_js@73368 aka 20230720.12 vs main ewma over 20 builds from 72928 to 73334

Click to see table

main

build_id build_number Commit latency factor pi_basic_mt_virtual_cft^ ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
72928 20230712.13 0.799723 61495.9 45762.6 46880.5 55048.8 12558.5 12672.7 4453.04 3523.86 3283.39 35535.6 2.51822e+07 44788.5 20046.2 1.67936e+07 20161.4 1.25993e+07 23021.4 1.25993e+07 6710.58 1.67936e+07 6564.9 6.30784e+06 1767.93 1.05021e+07 1445.06 1.05021e+07 1436 1.05021e+07 840580 1.18275e+06 8.15465e+06 3.08862e+07
72981 20230712.26 0.813809 65880.8 45598.2 44233.5 54556.6 12513.5 12865.7 4495.36 3520 3275.66 35275.6 2.51822e+07 48089.6 19966.3 1.88908e+07 20119.8 1.25993e+07 22909.6 1.25993e+07 6379.89 1.67936e+07 6516.4 6.30784e+06 1747.26 1.05021e+07 1443.44 1.05021e+07 1432.78 1.05021e+07 840750 1.17558e+06 8.15374e+06 3.10944e+07
72986 20230712.27 0.812176 56481.4 45590.3 47008.4 54528.8 12483.4 12724.4 4350.1 3379.21 3283.36 35645.6 2.51822e+07 50037.2 19693.3 1.88908e+07 19960 1.25993e+07 22888.3 1.25993e+07 6335.98 1.67936e+07 6467.1 6.30784e+06 1742.45 1.05021e+07 1438.04 1.05021e+07 1405.44 1.05021e+07 834873 1.17802e+06 8.14599e+06 3.09174e+07
73004 20230712.33 0.812968 62858.9 43847.4 46156.8 54946.3 12457.4 12783.8 4408.68 3491.91 3301.96 35930.1 2.51822e+07 47692.9 19911.9 1.88908e+07 20179.4 1.25993e+07 22792.5 1.25993e+07 6707.62 1.67936e+07 6563.5 6.30784e+06 1750.57 1.05021e+07 1438.9 1.05021e+07 1436.09 1.05021e+07 829483 1.17554e+06 8.14939e+06 3.07674e+07
73023 20230712.38 0.776197 63921.5 43776.5 46663.1 55196.6 12275.1 12853.7 4545.13 3535.92 3295.26 35346.2 2.51822e+07 47073.2 19803.6 1.88908e+07 20142.2 1.25993e+07 22794.7 1.25993e+07 6378.49 1.67936e+07 6475.7 6.30784e+06 1739.62 1.05021e+07 1437.25 1.05021e+07 1425.26 1.05021e+07 842747 1.1838e+06 8.15358e+06 3.13394e+07
73033 20230713.1 0.85485 65726.9 45771 47061.7 56071.3 12590.7 12839.3 4508.37 3557.15 3303.04 35459.9 2.51822e+07 48582 19966.7 1.88908e+07 20161.4 1.25993e+07 22890.6 1.25993e+07 6446.22 1.67936e+07 6478.2 6.30784e+06 1741.88 1.05021e+07 1441.24 1.05021e+07 1426.37 1.05021e+07 818389 1.18097e+06 8.153e+06 3.073e+07
73052 20230713.8 0.802062 70372.8 45795.1 47174.7 55397.1 12396.3 12835.5 4474.16 3550.68 3257.04 35363.7 2.51822e+07 47685.4 19736 1.88908e+07 20080.7 1.25993e+07 22670.8 1.25993e+07 6366.89 1.67936e+07 6497.5 6.30784e+06 1752.97 1.05021e+07 1433.62 1.05021e+07 1435.81 1.05021e+07 822746 1.17828e+06 8.15413e+06 3.03948e+07
73066 20230713.13 0.795208 68936.8 45653.8 47465.1 55269.1 12490.2 12819.2 4546.34 3555.72 3310.87 35726.5 2.30851e+07 43220.4 19952.2 1.88908e+07 20043.5 1.25993e+07 22849.1 1.25993e+07 6673.85 1.67936e+07 6469.8 6.30784e+06 1739.9 1.05021e+07 1436.77 1.05021e+07 1429.29 1.05021e+07 833479 1.17929e+06 8.15378e+06 3.10439e+07
73091 20230713.22 0.793568 63682.1 46198.4 47551.3 55228 12584.9 12689.9 4479.41 3544.88 3271.82 35187.3 2.51822e+07 44792.2 19794.1 1.88908e+07 20195.1 1.25993e+07 22861.7 1.25993e+07 6681.43 1.67936e+07 6508 6.30784e+06 1746.01 1.05021e+07 1442.07 1.05021e+07 1430.15 1.05021e+07 837043 1.17886e+06 8.15332e+06 3.07771e+07
73098 20230714.1 0.790865 64627 45877.5 47559.3 54965.2 12609.9 12662.7 4538.04 3556.02 3275.15 35632.3 2.51822e+07 48445.8 19988.6 1.88908e+07 20230 1.25993e+07 22972.5 1.25993e+07 6374.19 1.67936e+07 6511.7 6.30784e+06 1745.51 1.05021e+07 1432.05 1.05021e+07 1425.52 1.05021e+07 843704 1.18342e+06 8.15209e+06 3.16739e+07
73119 20230714.10 0.819362 69624.9 45837.8 47413.6 55492.5 12496 12661.6 4370.56 3530.65 3285.52 36055.4 2.51822e+07 48956 20021.7 1.88908e+07 20101.8 1.25993e+07 22955.1 1.25993e+07 6359.6 1.67936e+07 6473.5 6.30784e+06 1736.18 1.05021e+07 1435.26 1.05021e+07 1421.37 1.05021e+07 830236 1.18254e+06 8.13234e+06 2.99709e+07
73140 20230714.16 0.775764 64726.9 45939.2 47508.2 56422.4 12443.3 12725.2 4410.45 3556.53 3276.78 35787.7 2.51822e+07 46529 19982.8 1.88908e+07 20136 1.25993e+07 23086 1.25993e+07 6702.03 1.67936e+07 6473.1 6.30784e+06 1740.25 1.05021e+07 1437.95 1.05021e+07 1428 1.05021e+07 834004 1.18232e+06 8.02426e+06 3.15227e+07
73180 20230717.1 0.800222 62847.2 45834.3 46216.7 56263.1 12379.3 12902.1 4450.21 3464.92 3276.36 35716.3 2.51822e+07 43251.5 19924.6 1.88908e+07 20159.7 1.25993e+07 22998.5 1.25993e+07 6718.37 1.67936e+07 6519.5 6.30784e+06 1745.61 1.05021e+07 1444.06 1.05021e+07 1434.21 1.05021e+07 835650 1.18058e+06 8.15572e+06 3.10261e+07
73193 20230717.7 0.78772 69751.7 43736.8 46336 55360.9 12395.1 12427.6 4489.52 3540.58 3265.45 36011.4 2.51822e+07 47368.6 19894.2 1.88908e+07 20159.3 1.25993e+07 22907.9 1.25993e+07 6307.23 1.67936e+07 6514.9 6.30784e+06 1744.85 1.05021e+07 1440.41 1.05021e+07 1422.28 1.05021e+07 838900 1.1819e+06 8.15066e+06 3.07097e+07
73203 20230718.1 0.793044 62165.1 45920.6 42674.3 56150.9 12464.6 12757.4 4507.92 3532 3266.4 35794.8 2.51822e+07 45151 19822.2 1.88908e+07 20161.2 1.25993e+07 22927.2 1.25993e+07 6704.73 1.67936e+07 6511.9 6.30784e+06 1746.77 1.05021e+07 1441.47 1.05021e+07 1435.35 1.05021e+07 832649 1.17671e+06 8.15647e+06 3.08346e+07
73222 20230718.8 0.805911 60457.5 45753.2 47295.4 55714.2 12363.8 12886.6 4419.88 3524.46 3302.35 35990.6 2.51822e+07 46263.6 19907.3 1.88908e+07 20202.7 1.25993e+07 22911.9 1.25993e+07 6700.6 1.67936e+07 6562.7 6.30784e+06 1745.25 1.05021e+07 1443.47 1.05021e+07 1433.57 1.05021e+07 840209 1.17318e+06 8.15423e+06 3.02887e+07
73253 20230718.14 0.777385 58267.4 46099.1 46979.9 56428.6 12513.6 12701.8 4478.33 3561.56 3194.57 35660.2 2.51822e+07 44172.2 19676.5 1.88908e+07 20055.2 1.25993e+07 22817.8 1.25993e+07 6361 1.67936e+07 6428.3 6.30784e+06 1736.39 1.05021e+07 1436.52 1.05021e+07 1426 1.05021e+07 834585 1.17384e+06 8.17023e+06 3.07683e+07
73282 20230718.23 0.796516 57369.1 45505.1 46435.2 56228.4 12487.1 12915 4374.66 3541.61 3299.13 35647.1 2.51822e+07 46736.7 19967.8 1.88908e+07 20190.2 1.05021e+07 22909.1 1.25993e+07 6763.57 1.67936e+07 6519.8 6.30784e+06 1744.54 1.05021e+07 1439.03 1.05021e+07 1427.97 1.05021e+07 835153 1.18022e+06 8.15254e+06 3.07143e+07
73295 20230719.3 0.813958 74193.9 45809.8 42000.2 56193.1 12611.1 12906.4 4373.36 3552.29 3313.49 35703.7 2.30851e+07 48761 19855.4 1.88908e+07 20100.3 1.25993e+07 23035 1.25993e+07 6684.01 1.67936e+07 6518.1 6.30784e+06 1748.49 1.05021e+07 1442.45 1.05021e+07 1427.62 1.05021e+07 836495 1.18362e+06 8.15293e+06 3.08736e+07
73334 20230720.1 0.837609 62884 45559.8 47568.3 56224.2 12314.8 12825.3 4417.06 3564.71 3294.75 35932.5 2.51822e+07 46722.6 19828.5 1.88908e+07 20042.3 1.25993e+07 23024 1.25993e+07 6710.13 1.67936e+07 6511.8 6.30784e+06 1764.63 1.05021e+07 1438.09 1.05021e+07 1429.68 1.05021e+07 838421 1.17085e+06 8.15274e+06 3.14583e+07

expose_cose_content_js

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ pi_ls_jwt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem hist_sgx_cft^ ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^
73311 20230719.8 0.801176 45899.3 46788 56982.6 12525.1 35419.8 2.51822e+07 59052.3 12649 4478.84 3534.36 19995.3 1.88908e+07 20252.1 1.25993e+07 3288.2 22918 1.25993e+07 6718.69 1.67936e+07 6495.8 6.30784e+06 48264.6 1740.98 1.05021e+07 1422.21 1.05021e+07 1428.92 1.05021e+07 818234 1.16809e+06 8.15429e+06 3.08007e+07
73349 20230720.8 0.832362 43851.9 46259.1 55431.7 12437.7 35834 2.51822e+07 62652.5 12681.8 4494.64 3550.68 20039.2 1.88908e+07 20252.3 1.25993e+07 3314.32 23047.7 1.25993e+07 6727.73 1.67936e+07 6517.7 6.30784e+06 47950.3 1745.66 1.05021e+07 1437.14 1.05021e+07 1430.54 1.05021e+07 826891 1.17438e+06 8.15504e+06 3.07332e+07
73368 20230720.12 0.814586 43864.2 46267.2 56111.9 12459.4 35980.2 2.30851e+07 67707.9 12299.1 4510.96 3571.95 20090.8 1.88908e+07 20217.9 1.25993e+07 3292.66 22938.1 1.25993e+07 6749.07 1.67936e+07 6512.8 6.30784e+06 48269.2 1742.03 1.05021e+07 1437.19 1.05021e+07 1430.57 1.05021e+07 838567 1.17811e+06 8.13564e+06 3.07328e+07

images

Julien Maffre added 2 commits July 19, 2023 14:39
@jumaffre jumaffre added auto-backport Automatically backport this PR to LTS branch 4.x-todo PRs which should be backported to 4.x labels Jul 20, 2023
@jumaffre jumaffre marked this pull request as ready for review July 20, 2023 10:19
@jumaffre jumaffre requested a review from a team July 20, 2023 10:19
jumaffre
jumaffre commented Jul 20, 2023
View reviewed changes
tests/infra/clients.py Outdated Show resolved Hide resolved
@jumaffre jumaffre enabled auto-merge (squash) July 20, 2023 14:25
@jumaffre jumaffre merged commit 95b14ee into microsoft:main Jul 20, 2023
@ghost
Copy link

ghost commented Jul 20, 2023

💔 All backports failed

Status Branch Result
❌ release/4.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 5465

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@jumaffre jumaffre mentioned this pull request Jul 20, 2023
Merged
@jumaffre jumaffre added the backported This PR was successfully backported to LTS branch label Jul 20, 2023
jumaffre added a commit to jumaffre/CCF that referenced this pull request Jul 20, 2023
@jumaffre
Expose COSE identity content in JS/TS apps (microsoft#5465)
e408d98 
(cherry picked from commit 95b14ee)
jumaffre added a commit that referenced this pull request Jul 20, 2023
@jumaffre
[release/4.x] Cherry pick: Expose COSE identity content in JS/TS apps (…
b341e14 
…#5465) (#5473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamayou achamayou achamayou approved these changes

Assignees
No one assigned
Labels
4.x-todo PRs which should be backported to 4.x auto-backport Automatically backport this PR to LTS branch backported This PR was successfully backported to LTS branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose COSE authn identity content in JS/TS
2 participants
@jumaffre @achamayou