Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and set default raft timeout #559

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Document and set default raft timeout #559

merged 1 commit into from
Nov 14, 2019

Conversation

jumaffre
Copy link
Contributor

Resolves #555 and #556.

@jumaffre jumaffre requested a review from a team as a code owner November 14, 2019 11:58
@ghost
Copy link

ghost commented Nov 14, 2019

images

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #559 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
- Coverage   78.65%   78.49%   -0.16%     
==========================================
  Files         140      140              
  Lines       10501    10508       +7     
==========================================
- Hits         8259     8248      -11     
- Misses       2242     2260      +18
Flag Coverage Δ
#e2e_BFT 50.73% <100%> (-0.11%) ⬇️
#e2e_CFT 73.41% <100%> (-0.06%) ⬇️
#unit_BFT 65.19% <ø> (-0.02%) ⬇️
#unit_CFT 72.74% <ø> (-0.19%) ⬇️
Impacted Files Coverage Δ
src/host/main.cpp 98.24% <100%> (+0.04%) ⬆️
src/tls/entropy.h 23.53% <0%> (-70.59%) ⬇️
src/consensus/pbft/libbyz/Certificate.h 46.67% <0%> (-7.33%) ⬇️
src/host/tcp.h 73.08% <0%> (-0.85%) ⬇️
src/tls/intel_drng.h 71.2% <0%> (-0.8%) ⬇️
src/consensus/raft/raft.h 83.86% <0%> (+1.27%) ⬆️

@jumaffre jumaffre merged commit ae9a416 into master Nov 14, 2019
@jumaffre jumaffre deleted the raft_timeout branch November 14, 2019 14:14
eddyashton pushed a commit to eddyashton/CCF that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Raft default timeout to reasonable value
4 participants