Generalise handling of serialisation errors #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 78.47% 78.31% -0.16%
==========================================
Files 140 140
Lines 10678 10688 +10
==========================================
- Hits 8379 8370 -9
- Misses 2299 2318 +19
|
|
|
achamayou
reviewed
Nov 21, 2019
achamayou
approved these changes
Nov 21, 2019
|
|
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
* Add params to batched app * Add test of exceptional serialisation failure * Catch exceptions and commit * Abort hope, all ye who fail to serialise * Add disabled run_to_destruction test * Decomment test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #338, we currently have no way to safely recover from serialisation failures. This PR adds some more tests which will trigger serialisation failures, and ensures that they all produce a consistent response - currently aborting the executing node.
There are a few other recovery methods we could investigate here, in particular having the executing node rollback its KV, with an associated election to rollback consensus state. This may let the network recover with all nodes still alive, but needs some further thought. We hope to mitigate this risk in future with verified serialisers and increased enclave memory limits.