-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-threaded access to non-TLS servers (eg - SNP nodes fetching endorsements from THIM) #6836
Fix multi-threaded access to non-TLS servers (eg - SNP nodes fetching endorsements from THIM) #6836
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
2 open questions on this: I think this is a sufficient fix, we have a green run where we previously had consistent reds. But also had a single red run on this final version of the code. I think that's something unrelatedly flaky in
But will try a few more runs to confirm. I was hoping to leave on the |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
#6830 includes a bunch of debugging hacks to try and get a repro of the failure in virtual, to isolate the segfault. Includes a tiny THIM shim server.
This is a cleaner version of that, hopefully including the minimal changes for a CI repro (multi-threaded SNP CI) and the minimal fixes (dispatch send_data by threads, and add a
Mutex
inQuoteEndorsementsClient
).