-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some performance related issues #940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashamis
commented
Mar 10, 2020
•
edited by olgavrou
Loading
edited by olgavrou
- big request table will use an intrusive linked list so when an item is removed it can be done in O(1)
- the checkpoint in pbft is now only used for marking stable and therefore does not need to be signed
- the request queue will now have a queue per thread. This allows us to maintain session consistency while ensuring that we have enough work for all execution threads
- bring the intrusive double linked list from snmalloc
- print a request time series (second granularity) when collecting other metrics
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 68.96% 68.43% -0.54%
==========================================
Files 100 101 +1
Lines 7820 7978 +158
==========================================
+ Hits 5393 5459 +66
- Misses 2427 2519 +92
|
adding_things@5895 aka 20200311.9 vs master ewma over 30 builds from 5534 to 5893 |
olgavrou
reviewed
Mar 11, 2020
olgavrou
reviewed
Mar 11, 2020
olgavrou
reviewed
Mar 11, 2020
olgavrou
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.