More PBFT perf changes #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashamis
commented
Mar 11, 2020
ashamis
commented
- larger max number of requests in a pre-prepare
- updated what we sign as proof that a pre-prepare was accepted
achamayou
approved these changes
Mar 11, 2020
olgavrou
reviewed
Mar 11, 2020
| @@ -464,8 +464,7 @@ void ClientProxy<T, C>::retransmit() | |||
| RequestContext* ctx = head; | |||
| Request* out_req = ctx->req.get(); | |||
|
|
|||
| LOG_DEBUG << "Retransmitting req id: " << out_req->request_id() | |||
| << std::endl; | |||
| LOG_INFO_FMT("Retransmitting req id: {}", out_req->request_id()); | |||
olgavrou
approved these changes
Mar 11, 2020
|
pbft_more@5912 aka 20200311.18 vs master ewma over 30 builds from 5589 to 5908 |
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.