0.8 install fixes #945
Merged
0.8 install fixes #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Mar 12, 2020
|
fix_0.8_install@5978 aka 20200312.18 vs master ewma over 30 builds from 5654 to 5972 |
achamayou
approved these changes
Mar 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
==========================================
+ Coverage 68.46% 68.55% +0.09%
==========================================
Files 103 103
Lines 8076 8073 -3
==========================================
+ Hits 5529 5534 +5
+ Misses 2547 2539 -8
|
added 2 commits
March 12, 2020 16:32
eddyashton
pushed a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two issues with our 0.8 install:
generated/folder (containing the EDL definitions) was no longer copied to our install directory but was still referenced as an include directory for all our targets.networkencryption.hfile (included by our apps viaserialization.h) includedcryptobox.h, which includes some evercrypt that apps do not included (yet?).Once this is merged, I will cut 0.8.1.